Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10530)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 365463003: Implement scroll handler latency tracking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index b194491d7606763193f75e034c965c5b022ebeb7..941ccea207f9f3ba5fa248ad94e80eb36399bdfc 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -4517,8 +4517,7 @@ class SimpleSwapPromiseMonitor : public SwapPromiseMonitor {
int* set_needs_commit_count,
int* set_needs_redraw_count)
: SwapPromiseMonitor(layer_tree_host, layer_tree_host_impl),
- set_needs_commit_count_(set_needs_commit_count),
- set_needs_redraw_count_(set_needs_redraw_count) {}
+ set_needs_commit_count_(set_needs_commit_count) {}
virtual ~SimpleSwapPromiseMonitor() {}
@@ -4527,12 +4526,15 @@ class SimpleSwapPromiseMonitor : public SwapPromiseMonitor {
}
virtual void OnSetNeedsRedrawOnImpl() OVERRIDE {
- (*set_needs_redraw_count_)++;
+ ADD_FAILURE() << "Should not get called on main thread.";
+ }
+
+ virtual void OnForwardScrollUpdateToMainThreadOnImpl() OVERRIDE {
+ ADD_FAILURE() << "Should not get called on main thread.";
}
private:
int* set_needs_commit_count_;
- int* set_needs_redraw_count_;
};
class LayerTreeHostTestSimpleSwapPromiseMonitor : public LayerTreeHostTest {

Powered by Google App Engine
This is Rietveld 408576698