Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: cc/trees/layer_tree_host_impl.cc

Issue 365463003: Implement scroll handler latency tracking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host_impl.h" 5 #include "cc/trees/layer_tree_host_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 return layer_impl != NULL; 496 return layer_impl != NULL;
497 } 497 }
498 498
499 scoped_ptr<SwapPromiseMonitor> 499 scoped_ptr<SwapPromiseMonitor>
500 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor( 500 LayerTreeHostImpl::CreateLatencyInfoSwapPromiseMonitor(
501 ui::LatencyInfo* latency) { 501 ui::LatencyInfo* latency) {
502 return scoped_ptr<SwapPromiseMonitor>( 502 return scoped_ptr<SwapPromiseMonitor>(
503 new LatencyInfoSwapPromiseMonitor(latency, NULL, this)); 503 new LatencyInfoSwapPromiseMonitor(latency, NULL, this));
504 } 504 }
505 505
506 void LayerTreeHostImpl::QueueSwapPromiseForMainThreadScrollUpdate(
507 scoped_ptr<SwapPromise> swap_promise) {
508 swap_promises_for_main_thread_scroll_update_.push_back(swap_promise.Pass());
509 }
510
506 void LayerTreeHostImpl::TrackDamageForAllSurfaces( 511 void LayerTreeHostImpl::TrackDamageForAllSurfaces(
507 LayerImpl* root_draw_layer, 512 LayerImpl* root_draw_layer,
508 const LayerImplList& render_surface_layer_list) { 513 const LayerImplList& render_surface_layer_list) {
509 // For now, we use damage tracking to compute a global scissor. To do this, we 514 // For now, we use damage tracking to compute a global scissor. To do this, we
510 // must compute all damage tracking before drawing anything, so that we know 515 // must compute all damage tracking before drawing anything, so that we know
511 // the root damage rect. The root damage rect is then used to scissor each 516 // the root damage rect. The root damage rect is then used to scissor each
512 // surface. 517 // surface.
513 518
514 for (int surface_index = render_surface_layer_list.size() - 1; 519 for (int surface_index = render_surface_layer_list.size() - 1;
515 surface_index >= 0; 520 surface_index >= 0;
(...skipping 2125 matching lines...) Expand 10 before | Expand all | Expand 10 after
2641 // which the layer moved. 2646 // which the layer moved.
2642 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x()); 2647 gfx::Vector2dF perpendicular_axis(-applied_delta.y(), applied_delta.x());
2643 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis); 2648 pending_delta = MathUtil::ProjectVector(pending_delta, perpendicular_axis);
2644 2649
2645 if (gfx::ToRoundedVector2d(pending_delta).IsZero()) 2650 if (gfx::ToRoundedVector2d(pending_delta).IsZero())
2646 break; 2651 break;
2647 } 2652 }
2648 2653
2649 bool did_scroll_content = did_scroll_x || did_scroll_y; 2654 bool did_scroll_content = did_scroll_x || did_scroll_y;
2650 if (did_scroll_content) { 2655 if (did_scroll_content) {
2656 // If we are scrolling with an active scroll handler, forward latency
2657 // tracking information to the main thread so the delay introduced by the
2658 // handler is accounted for.
2659 if (scroll_affects_scroll_handler())
2660 NotifySwapPromiseMonitorsOfForwardingToMainThread();
2651 client_->SetNeedsCommitOnImplThread(); 2661 client_->SetNeedsCommitOnImplThread();
2652 SetNeedsRedraw(); 2662 SetNeedsRedraw();
2653 client_->RenewTreePriority(); 2663 client_->RenewTreePriority();
2654 } 2664 }
2655 2665
2656 // Scrolling along an axis resets accumulated root overscroll for that axis. 2666 // Scrolling along an axis resets accumulated root overscroll for that axis.
2657 if (did_scroll_x) 2667 if (did_scroll_x)
2658 accumulated_root_overscroll_.set_x(0); 2668 accumulated_root_overscroll_.set_x(0);
2659 if (did_scroll_y) 2669 if (did_scroll_y)
2660 accumulated_root_overscroll_.set_y(0); 2670 accumulated_root_overscroll_.set_y(0);
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2942 for (size_t i = 0; i < layer_impl->children().size(); ++i) 2952 for (size_t i = 0; i < layer_impl->children().size(); ++i)
2943 CollectScrollDeltas(scroll_info, layer_impl->children()[i]); 2953 CollectScrollDeltas(scroll_info, layer_impl->children()[i]);
2944 } 2954 }
2945 2955
2946 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() { 2956 scoped_ptr<ScrollAndScaleSet> LayerTreeHostImpl::ProcessScrollDeltas() {
2947 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet()); 2957 scoped_ptr<ScrollAndScaleSet> scroll_info(new ScrollAndScaleSet());
2948 2958
2949 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer()); 2959 CollectScrollDeltas(scroll_info.get(), active_tree_->root_layer());
2950 scroll_info->page_scale_delta = active_tree_->page_scale_delta(); 2960 scroll_info->page_scale_delta = active_tree_->page_scale_delta();
2951 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta); 2961 active_tree_->set_sent_page_scale_delta(scroll_info->page_scale_delta);
2962 scroll_info->swap_promises.swap(swap_promises_for_main_thread_scroll_update_);
2952 2963
2953 return scroll_info.Pass(); 2964 return scroll_info.Pass();
2954 } 2965 }
2955 2966
2956 void LayerTreeHostImpl::SetFullRootLayerDamage() { 2967 void LayerTreeHostImpl::SetFullRootLayerDamage() {
2957 SetViewportDamage(gfx::Rect(DrawViewportSize())); 2968 SetViewportDamage(gfx::Rect(DrawViewportSize()));
2958 } 2969 }
2959 2970
2960 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) { 2971 void LayerTreeHostImpl::RunOnDemandRasterTask(Task* on_demand_raster_task) {
2961 DCHECK(on_demand_task_graph_runner_); 2972 DCHECK(on_demand_task_graph_runner_);
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
3355 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) { 3366 void LayerTreeHostImpl::RemoveSwapPromiseMonitor(SwapPromiseMonitor* monitor) {
3356 swap_promise_monitor_.erase(monitor); 3367 swap_promise_monitor_.erase(monitor);
3357 } 3368 }
3358 3369
3359 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() { 3370 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfSetNeedsRedraw() {
3360 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin(); 3371 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3361 for (; it != swap_promise_monitor_.end(); it++) 3372 for (; it != swap_promise_monitor_.end(); it++)
3362 (*it)->OnSetNeedsRedrawOnImpl(); 3373 (*it)->OnSetNeedsRedrawOnImpl();
3363 } 3374 }
3364 3375
3376 void LayerTreeHostImpl::NotifySwapPromiseMonitorsOfForwardingToMainThread() {
3377 std::set<SwapPromiseMonitor*>::iterator it = swap_promise_monitor_.begin();
3378 for (; it != swap_promise_monitor_.end(); it++)
3379 (*it)->OnForwardScrollUpdateToMainThreadOnImpl();
3380 }
3381
3365 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) { 3382 void LayerTreeHostImpl::RegisterPictureLayerImpl(PictureLayerImpl* layer) {
3366 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) == 3383 DCHECK(std::find(picture_layers_.begin(), picture_layers_.end(), layer) ==
3367 picture_layers_.end()); 3384 picture_layers_.end());
3368 picture_layers_.push_back(layer); 3385 picture_layers_.push_back(layer);
3369 } 3386 }
3370 3387
3371 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) { 3388 void LayerTreeHostImpl::UnregisterPictureLayerImpl(PictureLayerImpl* layer) {
3372 std::vector<PictureLayerImpl*>::iterator it = 3389 std::vector<PictureLayerImpl*>::iterator it =
3373 std::find(picture_layers_.begin(), picture_layers_.end(), layer); 3390 std::find(picture_layers_.begin(), picture_layers_.end(), layer);
3374 DCHECK(it != picture_layers_.end()); 3391 DCHECK(it != picture_layers_.end());
3375 picture_layers_.erase(it); 3392 picture_layers_.erase(it);
3376 } 3393 }
3377 3394
3378 } // namespace cc 3395 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_host_impl.h ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698