Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 365463002: rAc: When filling partial autofill data, don't fill across dialog sections. (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

rAc: When filling partial autofill data, don't fill across dialog sections. BUG=359420 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281791

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -16 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 3 chunks +25 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Evan Stade
6 years, 5 months ago (2014-06-30 21:48:01 UTC) #1
groby-ooo-7-16
LGTM % comment nit https://codereview.chromium.org/365463002/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/365463002/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc#newcode675 chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:675: // Adding a new billing ...
6 years, 5 months ago (2014-06-30 22:01:31 UTC) #2
Evan Stade
https://codereview.chromium.org/365463002/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc File chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc (right): https://codereview.chromium.org/365463002/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc#newcode675 chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc:675: // Adding a new billing address. On 2014/06/30 22:01:31, ...
6 years, 5 months ago (2014-06-30 22:16:47 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-07 22:29:14 UTC) #4
Evan Stade
The CQ bit was unchecked by estade@chromium.org
6 years, 5 months ago (2014-07-07 22:29:19 UTC) #5
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-07 22:30:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/365463002/20001
6 years, 5 months ago (2014-07-07 22:32:53 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-08 01:07:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 01:50:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/90428)
6 years, 5 months ago (2014-07-08 01:50:06 UTC) #10
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-08 17:52:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/365463002/20001
6 years, 5 months ago (2014-07-08 17:55:10 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 19:21:33 UTC) #13
Message was sent while issue was closed.
Change committed as 281791

Powered by Google App Engine
This is Rietveld 408576698