Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/analysis_server/lib/src/context_directory_manager.dart

Issue 365443002: Handle a failure in "pub list-package-dirs". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/package_map_provider.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_directory_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_directory_manager.dart b/pkg/analysis_server/lib/src/context_directory_manager.dart
index 0c6ba7d5f103399ffae62c2f772a081cee4eca70..4fdd9f4e6b2d92f022457b047cac6c747f37c1fa 100644
--- a/pkg/analysis_server/lib/src/context_directory_manager.dart
+++ b/pkg/analysis_server/lib/src/context_directory_manager.dart
@@ -118,7 +118,6 @@ abstract class ContextDirectoryManager {
});
File pubspecFile = folder.getChild(PUBSPEC_NAME);
PackageMapInfo packageMapInfo = packageMapProvider.computePackageMap(folder);
- // TODO(paulberry): handle null return from computePackageMap.
info.packageMapDependencies = packageMapInfo.dependencies;
// TODO(paulberry): if any of the dependencies is outside of [folder],
// we'll need to watch their parent folders as well.
@@ -185,7 +184,6 @@ abstract class ContextDirectoryManager {
// while we're rerunning "pub list", since any analysis we complete while
// "pub list" is in progress is just going to get thrown away anyhow.
PackageMapInfo packageMapInfo = packageMapProvider.computePackageMap(folder);
- // TODO(paulberry): handle null return from computePackageMap.
info.packageMapDependencies = packageMapInfo.dependencies;
updateContextPackageMap(folder, packageMapInfo.packageMap);
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/package_map_provider.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698