Issue 365303003: ui: Fold ime gypi files directly into their main targets (ui_base and ui_unittests).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365303003: ui: Fold ime gypi files directly into their main targets (ui_base and ui_unittests). (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
sky, Yuki

CC:
chromium-reviews, brettw, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

ui: Fold ime gypi files directly into their main targets (ui_base and ui_unittests). This simplifies the management and will also make the conversion to GN easier. BUG=299841 TEST=ui_unittests R=yukishiino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284211

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -185 lines)			Patch
D	ui/base/ime/ime.gypi	View	1 2	1 chunk	+0 lines, -127 lines	0 comments	Download
D	ui/base/ime/ime_test_support.gypi	View	1 2	1 chunk	+0 lines, -12 lines	0 comments	Download
D	ui/base/ime/ime_unittests.gypi	View	1 2	1 chunk	+0 lines, -29 lines	0 comments	Download
M	ui/base/ui_base.gyp	View	1 2 3 4	6 chunks	+117 lines, -14 lines	0 comments	Download
M	ui/ui_unittests.gyp	View	1 2	3 chunks	+19 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/365303003/100001

6 years, 5 months ago (2014-07-18 19:24:41 UTC) #5

Message was sent while issue was closed.

Change committed as 284211