Issue 365293002: Restore GC state after painting with a "reference" [url(#foo)] clip-path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365293002: Restore GC state after painting with a "reference" [url(#foo)] clip-path (Closed)

Created:
6 years, 5 months ago by fs

Modified:
6 years, 5 months ago

Reviewers:
krit, f(malita)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Restore GC state after painting with a "reference" [url(#foo)] clip-path If the referenced 'clipPath' is a simple (single shape), the GC state is mutated with the clip-path shape. It's however not guaranteed that the GC state is restored - and hence the clip removed - before painting later content. Make sure the state is restored at the exit of RenderLayer::paintLayerContents by using a GCSS. Convert the 'clip-path: <shape>'-case to use the GCSS as well. BUG=391291 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177586

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -7 lines)			Patch
A	LayoutTests/css3/masking/clip-path-reference-restore.html	View	1 chunk	+25 lines, -0 lines	0 comments	Download
A +	LayoutTests/css3/masking/clip-path-reference-restore-expected.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	4 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/365293002/1

6 years, 5 months ago (2014-07-07 13:43:27 UTC) #4

Message was sent while issue was closed.

Change committed as 177586

Expand Messages | Collapse Messages