Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 365293002: Restore GC state after painting with a "reference" [url(#foo)] clip-path (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
Reviewers:
krit, f(malita)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Restore GC state after painting with a "reference" [url(#foo)] clip-path If the referenced 'clipPath' is a simple (single shape), the GC state is mutated with the clip-path shape. It's however not guaranteed that the GC state is restored - and hence the clip removed - before painting later content. Make sure the state is restored at the exit of RenderLayer::paintLayerContents by using a GCSS. Convert the 'clip-path: <shape>'-case to use the GCSS as well. BUG=391291 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
A LayoutTests/css3/masking/clip-path-reference-restore.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/css3/masking/clip-path-reference-restore-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fs
6 years, 5 months ago (2014-07-04 15:27:12 UTC) #1
f(malita)
lgtm
6 years, 5 months ago (2014-07-07 13:35:52 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 5 months ago (2014-07-07 13:42:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/365293002/1
6 years, 5 months ago (2014-07-07 13:43:27 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 13:51:45 UTC) #5
Message was sent while issue was closed.
Change committed as 177586

Powered by Google App Engine
This is Rietveld 408576698