Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 365253003: Add InspectorInstrumentation over ExecutionContextTask and async call stacks for DataTransferItem.g… (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 5 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+worker_chromium.org, aandrey+blink_chromium.org, rwlbuis, falken, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, horo+watch_chromium.org, sergeyv+blink_chromium.org, watchdog-blink-watchlist_google.com
Project:
blink
Visibility:
Public.

Description

Add InspectorInstrumentation over ExecutionContextTask and async call stacks for DataTransferItem.getAsString. This instrumentation is needed to support async call stacks in DevTools on various async scenarios. An example test is for DataTransferItem.getAsString() call. BUG=272416 R=pfeldman, yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177772

Patch Set 1 #

Total comments: 5

Patch Set 2 : rebased #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -13 lines) Patch
A LayoutTests/inspector/sources/debugger/async-callstack-get-as-string.html View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/async-callstack-get-as-string-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/clipboard/DataTransferItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContextTask.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/MainThreadTaskRunner.cpp View 1 2 4 chunks +13 lines, -0 lines 0 comments Download
M Source/core/dom/StringCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StringCallback.cpp View 1 2 2 chunks +12 lines, -5 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 3 chunks +30 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 chunks +25 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerRunLoop.cpp View 1 2 3 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
aandrey
6 years, 5 months ago (2014-07-04 13:52:36 UTC) #1
yurys
lgtm https://codereview.chromium.org/365253003/diff/1/Source/core/dom/MainThreadTaskRunner.cpp File Source/core/dom/MainThreadTaskRunner.cpp (right): https://codereview.chromium.org/365253003/diff/1/Source/core/dom/MainThreadTaskRunner.cpp#newcode88 Source/core/dom/MainThreadTaskRunner.cpp:88: // [InspectorInstrumentation] No need to instrument inspector tasks. ...
6 years, 5 months ago (2014-07-07 15:44:47 UTC) #2
aandrey
https://codereview.chromium.org/365253003/diff/1/Source/core/dom/MainThreadTaskRunner.cpp File Source/core/dom/MainThreadTaskRunner.cpp (right): https://codereview.chromium.org/365253003/diff/1/Source/core/dom/MainThreadTaskRunner.cpp#newcode88 Source/core/dom/MainThreadTaskRunner.cpp:88: // [InspectorInstrumentation] No need to instrument inspector tasks. On ...
6 years, 5 months ago (2014-07-08 08:48:03 UTC) #3
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 08:48:29 UTC) #4
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 08:49:05 UTC) #5
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 08:52:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/365253003/40001
6 years, 5 months ago (2014-07-08 08:54:23 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-08 09:59:41 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 10:22:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/31769)
6 years, 5 months ago (2014-07-08 10:22:51 UTC) #10
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 11:56:20 UTC) #11
aandrey
The CQ bit was unchecked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 11:56:35 UTC) #12
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 14:07:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/365253003/40001
6 years, 5 months ago (2014-07-08 14:08:36 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-08 15:13:06 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 15:39:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/21721)
6 years, 5 months ago (2014-07-08 15:39:39 UTC) #17
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 15:44:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/365253003/40001
6 years, 5 months ago (2014-07-08 15:44:59 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-08 16:18:53 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 16:42:44 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/31884)
6 years, 5 months ago (2014-07-08 16:42:46 UTC) #22
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-08 18:45:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/365253003/40001
6 years, 5 months ago (2014-07-08 18:46:08 UTC) #24
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-08 19:52:28 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 20:18:19 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/31984)
6 years, 5 months ago (2014-07-08 20:18:20 UTC) #27
aandrey
Added Source/core/dom/ExecutionContextTaskNames.in to generate AtomicString names for ExecutionContextTask's. PTAL.
6 years, 5 months ago (2014-07-09 15:15:58 UTC) #28
aandrey
On 2014/07/09 15:15:58, aandrey wrote: > Added Source/core/dom/ExecutionContextTaskNames.in to generate AtomicString > names for ExecutionContextTask's. ...
6 years, 5 months ago (2014-07-09 18:00:22 UTC) #29
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-09 19:11:31 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/365253003/100001
6 years, 5 months ago (2014-07-09 19:12:37 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-09 20:13:43 UTC) #32
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 21:13:53 UTC) #33
Message was sent while issue was closed.
Change committed as 177772

Powered by Google App Engine
This is Rietveld 408576698