Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 365223002: Clean up redundant header files in navigatorcontentutils (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, gyuyoung.kim_webkit.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clean up redundant header files inclusion in navigatorcontentutils In previous CLs, redundant header files were included by files of navigator content utils. This cl removes those files as well as redundant forward declaration. Additionally this cl uses forward declaration for KURL in NavigatorContentUtilsClientMock.h. Finally this cl adds OwnPtr.h to NavigatorContentUtils.h because blink coding style prefers to include directly when oilpan is disabled. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177510

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
gyuyoung-inactive
6 years, 5 months ago (2014-07-04 04:05:05 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-04 04:18:12 UTC) #2
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-04 04:18:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/365223002/40001
6 years, 5 months ago (2014-07-04 04:19:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-04 05:40:41 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 06:00:00 UTC) #6
Message was sent while issue was closed.
Change committed as 177510

Powered by Google App Engine
This is Rietveld 408576698