Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 365163002: Use correct destination rectangle in FEComposite w/ type='in' (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Use correct destination rectangle in FEComposite w/ type='in' When one of the inputs are larger than the other, the destination will assume the size of the smaller. When drawing the input onto the destination however, the size of the buffer itself is always used. This means that the source will be stretched onto a (too large) destination rectangle. Destination and sources should always be the same dimensions in this particular case, so make sure they are by simply adjusting the computed destination rectangle based by the effects paint rect, hence retaining the computed dimensions. BUG=391200 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177536

Patch Set 1 #

Patch Set 2 : Attempt to Mac-proof TC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
A LayoutTests/css3/filters/fecomposite-non-zero-inoffset.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/css3/filters/fecomposite-non-zero-inoffset-expected.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/graphics/filters/FEComposite.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
6 years, 5 months ago (2014-07-03 16:11:38 UTC) #1
Stephen White
LGTM
6 years, 5 months ago (2014-07-03 16:30:25 UTC) #2
fs
The CQ bit was checked by fs@opera.com
6 years, 5 months ago (2014-07-04 07:46:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/365163002/1
6 years, 5 months ago (2014-07-04 07:46:42 UTC) #4
fs
The CQ bit was unchecked by fs@opera.com
6 years, 5 months ago (2014-07-04 07:46:59 UTC) #5
fs
The CQ bit was checked by fs@opera.com
6 years, 5 months ago (2014-07-04 10:30:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/365163002/20001
6 years, 5 months ago (2014-07-04 10:30:59 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 11:36:22 UTC) #8
Message was sent while issue was closed.
Change committed as 177536

Powered by Google App Engine
This is Rietveld 408576698