chrome/test/mini_installer/test_installer.py - Issue 365143002: mini_installer code cleanups (no functional changes).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer/test_installer.py

Issue 365143002: mini_installer code cleanups (no functional changes). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: flip component logic Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/mini_installer/test_installer.py

diff --git a/chrome/test/mini_installer/test_installer.py b/chrome/test/mini_installer/test_installer.py

index af6b2c3a33108757dd5dc9505d06a2325b18969f..25f5baff8aa7ba26a7738c00f3bc0636bd013ee0 100644

--- a/chrome/test/mini_installer/test_installer.py

+++ b/chrome/test/mini_installer/test_installer.py

@@ -254,7 +254,7 @@ def IsComponentBuild(mini_installer_path):

query_command = mini_installer_path + ' --query-component-build'

script_dir = os.path.dirname(os.path.abspath(__file__))

exit_status = subprocess.call(query_command, shell=True, cwd=script_dir)

- return exit_status != 0

+ return exit_status == 0

def main():

« no previous file with comments | « chrome/installer/mini_installer/mini_installer_constants.cc ('k') | no next file » | no next file with comments »