mini_installer code cleanups (no functional changes).

chrome/installer/mini_installer/mini_installer_constants.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_MINI_INSTALLER_MINI_INSTALLER_CONSTANTS_H_
+#define CHROME_INSTALLER_MINI_INSTALLER_MINI_INSTALLER_CONSTANTS_H_
+
+namespace mini_installer {
+
+// Various filenames and prefixes.
+// The target name of the installer extracted from resources.

[gab, 2014/07/07 13:45:01]

Typically with pref names and constants I've noticed that we put the
descriptions/comments in the .cc file; this is nice as it avoids having to look
at 2 files when searching for the constant's value and its associated
definition.

e.g. chrome/common/pref_names.cc, chrome_switches.cc

[grt (UTC plus 2), 2014/07/07 14:24:06]

Done.

+extern const wchar_t kSetupExe[];
+// The prefix of the chrome archive resource.
+extern const wchar_t kChromeArchivePrefix[];
+// The prefix of the installer resource.
+extern const wchar_t kSetupPrefix[];
+
+// Command line switch names for setup.exe (sans switch prefixes).

[gab, 2014/07/07 13:45:01]

I didn't originally understand what was meant by "sans switch prefixes"; until I
realized you meant without "--" prefix.

I don't think this needs to be mentioned (chrome_switches.(cc|h) uses the same
scheme and doesn't mention it).

[grt (UTC plus 2), 2014/07/07 14:24:06]

i mentioned it because it is a change from the old constants, which included "
--" (which i really didn't like). the point was to make it clear to those who
knew the old code that it's not broken now.

+extern const wchar_t kCmdInstallArchive[];
+extern const wchar_t kCmdUpdateSetupExe[];
+extern const wchar_t kCmdNewSetupExe[];
+
+// Temp directory prefix that this process creates.
+extern const wchar_t kTempPrefix[];
+// ap value suffix to force subsequent updates to use the full rather than
+// differential updater.
+extern const wchar_t kFullInstallerSuffix[];
+// ap value tag for a multi-install product.
+extern const wchar_t kMultiInstallTag[];
+
+// The resource types that would be unpacked from the mini installer.
+// Uncompressed binary.
+extern const wchar_t kBinResourceType[];
+// LZ compressed binary.
+extern const wchar_t kLZCResourceType[];
+// 7zip archive.
+extern const wchar_t kLZMAResourceType[];
+
+// Registry value names.
+// The name of an app's Client State registry value that holds its tag/channel.
+extern const wchar_t kApRegistryValue[];
+// The name of the value in kCleanupRegistryKey that tells the installer not to
+// delete extracted files.
+extern const wchar_t kCleanupRegistryValue[];
+// The name of an app's Client State registry value that holds the path to its
+// uninstaller.
+extern const wchar_t kUninstallRegistryValue[];
+
+// Registry key paths.
+// The path to the key containing each app's Client State registry key.
+extern const wchar_t kClientStateKeyBase[];
+// The path to the key in which kCleanupRegistryValue is found.
+extern const wchar_t kCleanupRegistryKey[];
+
+// One gigabyte is the biggest resource size that it can handle.
+extern const size_t kMaxResourceSize;
+
+}  // namespace mini_installer
+
+#endif  // CHROME_INSTALLER_MINI_INSTALLER_MINI_INSTALLER_CONSTANTS_H_