chrome/installer/mini_installer/exit_code.h - Issue 365143002: mini_installer code cleanups (no functional changes).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/mini_installer/exit_code.h

Issue 365143002: mini_installer code cleanups (no functional changes). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_INSTALLER_MINI_INSTALLER_EXIT_CODE_H_

	6 #define CHROME_INSTALLER_MINI_INSTALLER_EXIT_CODE_H_

	7

	8 namespace mini_installer {

	9

	10 // mini_installer process exit codes (the underlying type is uint32_t).

	11 enum ExitCode {

	12 SUCCESS_EXIT_CODE = 0,

	13 GENERIC_ERROR = 1,

	14 GENERIC_INITIALIZATION_FAILURE = 101,
	gab 2014/07/07 13:45:01 Why is there a gap here? Add a comment above stati Why is there a gap here? Add a comment above stating where new codes should go given it doesn't look like a strictly incremental list of exit codes. grt (UTC plus 2) 2014/07/07 14:24:06 Done. Show quoted text On 2014/07/07 13:45:01, gab wrote: > Why is there a gap here? Add a comment above stating where new codes should go > given it doesn't look like a strictly incremental list of exit codes. Done.
	15 GENERIC_UNPACKING_FAILURE = 102,

	16 GENERIC_SETUP_FAILURE = 103,

	17 };

	18

	19 } // namespace mini_installer

	20

	21 #endif // CHROME_INSTALLER_MINI_INSTALLER_EXIT_CODE_H_

OLD	NEW