chrome/installer/util/google_update_settings.cc - Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_settings.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r281743 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_metrics_service_client.cc ('K') | « chrome/installer/util/google_update_settings.h ('k') | components/breakpad/app/breakpad_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/google_update_settings.cc

diff --git a/chrome/installer/util/google_update_settings.cc b/chrome/installer/util/google_update_settings.cc

index 81e33ed1138748678c355c1638154e496608ac9f..0f583c00957b17c40240dbde20ac0a9b5e8511b6 100644

--- a/chrome/installer/util/google_update_settings.cc

+++ b/chrome/installer/util/google_update_settings.cc

@@ -296,14 +296,14 @@ bool GoogleUpdateSettings::SetCollectStatsConsentAtLevel(bool system_install,

return (result == ERROR_SUCCESS);

}

-bool GoogleUpdateSettings::GetMetricsId(std::string* metrics_id) {

+bool GoogleUpdateSettings::RetrieveMetricsId(std::string* metrics_id) {

base::string16 metrics_id16;

bool rv = ReadGoogleUpdateStrKey(google_update::kRegMetricsId, &metrics_id16);

*metrics_id = base::UTF16ToUTF8(metrics_id16);

return rv;

}

-bool GoogleUpdateSettings::SetMetricsId(const std::string& metrics_id) {

+bool GoogleUpdateSettings::SaveMetricsId(const std::string& metrics_id) {

base::string16 metrics_id16 = base::UTF8ToUTF16(metrics_id);

return WriteGoogleUpdateStrKey(google_update::kRegMetricsId, metrics_id16);

}