chrome/browser/chrome_content_browser_client.cc - Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r281743 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/client_util.cc ('k') | chrome/browser/google/google_update_settings_posix.cc » ('j') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 3d3c3c2b0fff4cd4668a4d070380bb47cda6b8d8..374f5a3e4b0a5b5d60c80309b8fbcffeda636dbf 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -1468,7 +1468,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(

#if defined(OS_POSIX)

if (breakpad::IsCrashReporterEnabled()) {

std::string enable_crash_reporter;

- GoogleUpdateSettings::GetMetricsId(&enable_crash_reporter);

+ GoogleUpdateSettings::RetrieveMetricsID(&enable_crash_reporter);

command_line->AppendSwitchASCII(switches::kEnableCrashReporter,

enable_crash_reporter);

}