Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

chrome/installer/util/google_update_settings.h

Index: chrome/installer/util/google_update_settings.h
diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h
index a2ff11db8e61b3b320c7d38324dc18bf6849d6c9..f1b27debe52c580574ac4653301dcc0d9d0f9868 100644
--- a/chrome/installer/util/google_update_settings.h
+++ b/chrome/installer/util/google_update_settings.h
@@ -86,12 +86,12 @@ class GoogleUpdateSettings {
                                             bool consented);
 #endif
 
-  // Returns the metrics id set in the registry (that can be used in crash
-  // reports). If none found, returns empty string.
-  static bool GetMetricsId(std::string* metrics_id);
+  // Returns the metrics client-id backed up in the registry. If none found,
+  // returns empty string.
+  static bool RetrieveMetricsID(std::string* metrics_id);

[grt (UTC plus 2), 2014/07/08 14:39:40]

Why is this called "MetricsID" here and "ClientID" elsewhere? Are they not the
same thing?

[gab, 2014/07/08 18:42:23]

Went with "ClientId" everywhere (or do you think it should be "ClientID"? the
code was inconsistent with this too)

 
-  // Sets the metrics id to be used in crash reports.
-  static bool SetMetricsId(const std::string& metrics_id);
+  // Saves a backup of the metrics client-id in the registry.
+  static bool SaveMetricsID(const std::string& metrics_id);
 
   // Sets the machine-wide EULA consented flag required on OEM installs.
   // Returns false if the setting could not be recorded.