Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

chrome/installer/util/google_update_settings.h

Index: chrome/installer/util/google_update_settings.h
diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h
index b7bf6125613e9c0e492566dd3be7474fc9d01b25..29cb8f2fdba826e239c56d564efb230cd4ef06ea 100644
--- a/chrome/installer/util/google_update_settings.h
+++ b/chrome/installer/util/google_update_settings.h
@@ -86,12 +86,12 @@ class GoogleUpdateSettings {
                                             bool consented);
 #endif
 
-  // Returns the metrics id set in the registry (that can be used in crash
-  // reports). If none found, returns empty string.
-  static bool GetMetricsId(std::string* metrics_id);
+  // Returns the metrics client-id backed up in the registry. If none found,

[grt (UTC plus 2), 2014/07/09 12:59:59]

nit: "client-id" doesn't seem to be used elsewhere. please use whichever of
"client id", "Client ID", "ClientID", etc... is most prevalent.

[gab, 2014/07/09 14:42:39]

Done.

+  // returns empty string.
+  static bool LoadMetricsClientId(std::string* metrics_id);
 
-  // Sets the metrics id to be used in crash reports.
-  static bool SetMetricsId(const std::string& metrics_id);
+  // Stores a backup of the metrics client-id in the registry.
+  static bool StoreMetricsClientId(const std::string& metrics_id);
 
   // Sets the machine-wide EULA consented flag required on OEM installs.
   // Returns false if the setting could not be recorded.