Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Side by Side Diff: components/metrics/test_metrics_service_client.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/metrics/test_metrics_service_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/metrics/test_metrics_service_client.h" 5 #include "components/metrics/test_metrics_service_client.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "components/metrics/metrics_log_uploader.h" 8 #include "components/metrics/metrics_log_uploader.h"
9 9
10 namespace metrics { 10 namespace metrics {
11 11
12 // static 12 // static
13 const char TestMetricsServiceClient::kBrandForTesting[] = "brand_for_testing"; 13 const char TestMetricsServiceClient::kBrandForTesting[] = "brand_for_testing";
14 14
15 TestMetricsServiceClient::TestMetricsServiceClient() 15 TestMetricsServiceClient::TestMetricsServiceClient()
16 : version_string_("5.0.322.0-64-devel") { 16 : version_string_("5.0.322.0-64-devel") {
17 } 17 }
18 18
19 TestMetricsServiceClient::~TestMetricsServiceClient() { 19 TestMetricsServiceClient::~TestMetricsServiceClient() {
20 } 20 }
21 21
22 void TestMetricsServiceClient::SetClientID(const std::string& client_id) { 22 void TestMetricsServiceClient::SetMetricsClientId(
23 const std::string& client_id) {
23 client_id_ = client_id; 24 client_id_ = client_id;
24 } 25 }
25 26
26 bool TestMetricsServiceClient::IsOffTheRecordSessionActive() { 27 bool TestMetricsServiceClient::IsOffTheRecordSessionActive() {
27 return false; 28 return false;
28 } 29 }
29 30
30 std::string TestMetricsServiceClient::GetApplicationLocale() { 31 std::string TestMetricsServiceClient::GetApplicationLocale() {
31 return "en-US"; 32 return "en-US";
32 } 33 }
(...skipping 25 matching lines...) Expand all
58 } 59 }
59 60
60 scoped_ptr<MetricsLogUploader> TestMetricsServiceClient::CreateUploader( 61 scoped_ptr<MetricsLogUploader> TestMetricsServiceClient::CreateUploader(
61 const std::string& server_url, 62 const std::string& server_url,
62 const std::string& mime_type, 63 const std::string& mime_type,
63 const base::Callback<void(int)>& on_upload_complete) { 64 const base::Callback<void(int)>& on_upload_complete) {
64 return scoped_ptr<MetricsLogUploader>(); 65 return scoped_ptr<MetricsLogUploader>();
65 } 66 }
66 67
67 } // namespace metrics 68 } // namespace metrics
OLDNEW
« no previous file with comments | « components/metrics/test_metrics_service_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698