Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: components/breakpad/app/breakpad_client.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/breakpad/app/breakpad_client.h ('k') | components/breakpad/app/breakpad_linux.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/breakpad/app/breakpad_client.h" 5 #include "components/breakpad/app/breakpad_client.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace breakpad { 10 namespace breakpad {
11 11
12 namespace { 12 namespace {
13 13
14 BreakpadClient* g_client = NULL; 14 BreakpadClient* g_client = NULL;
15 15
16 } // namespace 16 } // namespace
17 17
18 void SetBreakpadClient(BreakpadClient* client) { 18 void SetBreakpadClient(BreakpadClient* client) {
19 g_client = client; 19 g_client = client;
20 } 20 }
21 21
22 BreakpadClient* GetBreakpadClient() { 22 BreakpadClient* GetBreakpadClient() {
23 DCHECK(g_client); 23 DCHECK(g_client);
24 return g_client; 24 return g_client;
25 } 25 }
26 26
27 BreakpadClient::BreakpadClient() {} 27 BreakpadClient::BreakpadClient() {}
28 BreakpadClient::~BreakpadClient() {} 28 BreakpadClient::~BreakpadClient() {}
29 29
30 void BreakpadClient::SetClientID(const std::string& client_id) { 30 void BreakpadClient::SetBreakpadClientIdFromGUID(
31 const std::string& client_guid) {
31 } 32 }
32 33
33 #if defined(OS_WIN) 34 #if defined(OS_WIN)
34 bool BreakpadClient::GetAlternativeCrashDumpLocation( 35 bool BreakpadClient::GetAlternativeCrashDumpLocation(
35 base::FilePath* crash_dir) { 36 base::FilePath* crash_dir) {
36 return false; 37 return false;
37 } 38 }
38 39
39 void BreakpadClient::GetProductNameAndVersion(const base::FilePath& exe_path, 40 void BreakpadClient::GetProductNameAndVersion(const base::FilePath& exe_path,
40 base::string16* product_name, 41 base::string16* product_name,
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 #if defined(OS_MACOSX) 118 #if defined(OS_MACOSX)
118 void BreakpadClient::InstallAdditionalFilters(BreakpadRef breakpad) { 119 void BreakpadClient::InstallAdditionalFilters(BreakpadRef breakpad) {
119 } 120 }
120 #endif 121 #endif
121 122
122 bool BreakpadClient::EnableBreakpadForProcess(const std::string& process_type) { 123 bool BreakpadClient::EnableBreakpadForProcess(const std::string& process_type) {
123 return false; 124 return false;
124 } 125 }
125 126
126 } // namespace breakpad 127 } // namespace breakpad
OLDNEW
« no previous file with comments | « components/breakpad/app/breakpad_client.h ('k') | components/breakpad/app/breakpad_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698