Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

chrome/common/crash_keys.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_CRASH_KEYS_H_
 #define CHROME_COMMON_CRASH_KEYS_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/debug/crash_logging.h"
 
 namespace base {
 class CommandLine;
 }
 
 namespace crash_keys {
 
 // Registers all of the potential crash keys that can be sent to the crash
 // reporting server. Returns the size of the union of all keys.
 size_t RegisterChromeCrashKeys();
 
-// Sets the GUID by which this crash reporting client can be identified.
-void SetClientID(const std::string& client_id);
+// Sets the ID (based on |client_guid| which may either be a full GUID or a
+// GUID that was already stripped from its dashes -- in either cases this method
+// will strip remaining dashes before setting the crash key) by which this crash
+// reporting client can be identified.
+void SetCrashClientIdFromGUID(const std::string& client_guid);
 
 // Sets the kSwitch and kNumSwitches keys based on the given |command_line|.
 void SetSwitchesFromCommandLine(const base::CommandLine* command_line);
 
 // Sets the list of active experiment/variations info.
 void SetVariationsList(const std::vector<std::string>& variations);
 
 // Sets the list of "active" extensions in this process. We overload "active" to
 // mean different things depending on the process type:
 // - browser: all enabled extensions
@@ skipping 102 matching lines @@
 // deliberate crash.
 extern const char kZombie[];
 extern const char kZombieTrace[];
 
 }  // namespace mac
 #endif
 
 }  // namespace crash_keys
 
 #endif  // CHROME_COMMON_CRASH_KEYS_H_