Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/app/chrome_breakpad_client.cc

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/chrome_breakpad_client.h ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_breakpad_client.h" 5 #include "chrome/app/chrome_breakpad_client.h"
6 6
7 #include "base/atomicops.h" 7 #include "base/atomicops.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 // A atomic counter to make each crash dump value name unique. 73 // A atomic counter to make each crash dump value name unique.
74 base::subtle::Atomic32 g_browser_crash_dump_count = 0; 74 base::subtle::Atomic32 g_browser_crash_dump_count = 0;
75 #endif 75 #endif
76 76
77 } // namespace 77 } // namespace
78 78
79 ChromeBreakpadClient::ChromeBreakpadClient() {} 79 ChromeBreakpadClient::ChromeBreakpadClient() {}
80 80
81 ChromeBreakpadClient::~ChromeBreakpadClient() {} 81 ChromeBreakpadClient::~ChromeBreakpadClient() {}
82 82
83 void ChromeBreakpadClient::SetClientID(const std::string& client_id) { 83 void ChromeBreakpadClient::SetBreakpadClientIdFromGUID(
84 crash_keys::SetClientID(client_id); 84 const std::string& client_guid) {
85 crash_keys::SetCrashClientIdFromGUID(client_guid);
85 } 86 }
86 87
87 #if defined(OS_WIN) 88 #if defined(OS_WIN)
88 bool ChromeBreakpadClient::GetAlternativeCrashDumpLocation( 89 bool ChromeBreakpadClient::GetAlternativeCrashDumpLocation(
89 base::FilePath* crash_dir) { 90 base::FilePath* crash_dir) {
90 // By setting the BREAKPAD_DUMP_LOCATION environment variable, an alternate 91 // By setting the BREAKPAD_DUMP_LOCATION environment variable, an alternate
91 // location to write breakpad crash dumps can be set. 92 // location to write breakpad crash dumps can be set.
92 scoped_ptr<base::Environment> env(base::Environment::Create()); 93 scoped_ptr<base::Environment> env(base::Environment::Create());
93 std::string alternate_crash_dump_location; 94 std::string alternate_crash_dump_location;
94 if (env->GetVar("BREAKPAD_DUMP_LOCATION", &alternate_crash_dump_location)) { 95 if (env->GetVar("BREAKPAD_DUMP_LOCATION", &alternate_crash_dump_location)) {
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 bool ChromeBreakpadClient::EnableBreakpadForProcess( 368 bool ChromeBreakpadClient::EnableBreakpadForProcess(
368 const std::string& process_type) { 369 const std::string& process_type) {
369 return process_type == switches::kRendererProcess || 370 return process_type == switches::kRendererProcess ||
370 process_type == switches::kPluginProcess || 371 process_type == switches::kPluginProcess ||
371 process_type == switches::kPpapiPluginProcess || 372 process_type == switches::kPpapiPluginProcess ||
372 process_type == switches::kZygoteProcess || 373 process_type == switches::kZygoteProcess ||
373 process_type == switches::kGpuProcess; 374 process_type == switches::kGpuProcess;
374 } 375 }
375 376
376 } // namespace chrome 377 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/app/chrome_breakpad_client.h ('k') | chrome/app/client_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698