Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: chrome/browser/history/history_backend_android.cc

Issue 365133003: Change AndroidHistoryProviderService to use CancelableTaskTracker (4/6) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.4
Patch Set: clang-format Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend_android.cc
diff --git a/chrome/browser/history/history_backend_android.cc b/chrome/browser/history/history_backend_android.cc
index 840e8ee348dbd0b89fbc8b548d3f3b5533423d4c..83776ec145a2552559a5cca70119d3c42b5d1fcd 100644
--- a/chrome/browser/history/history_backend_android.cc
+++ b/chrome/browser/history/history_backend_android.cc
@@ -8,17 +8,12 @@
namespace history {
-void HistoryBackend::InsertHistoryAndBookmark(
- scoped_refptr<InsertRequest> request,
+AndroidURLID HistoryBackend::InsertHistoryAndBookmark(
const HistoryAndBookmarkRow& row) {
- if (request->canceled())
- return;
-
AndroidURLID id = 0;
if (android_provider_backend_)
id = android_provider_backend_->InsertHistoryAndBookmark(row);
-
- request->ForwardResult(request->handle(), id != 0, id);
+ return id;
}
AndroidStatement* HistoryBackend::QueryHistoryAndBookmarks(
@@ -111,16 +106,11 @@ void HistoryBackend::CloseStatement(AndroidStatement* statement) {
// Search Term -----------------------------------------------------------------
-void HistoryBackend::InsertSearchTerm(scoped_refptr<InsertRequest> request,
- const SearchRow& row) {
- if (request->canceled())
- return;
-
+SearchTermID HistoryBackend::InsertSearchTerm(const SearchRow& row) {
SearchTermID id = 0;
if (android_provider_backend_)
id = android_provider_backend_->InsertSearchTerm(row);
-
- request->ForwardResult(request->handle(), id != 0, id);
+ return id;
}
void HistoryBackend::UpdateSearchTerms(
« chrome/browser/history/history_backend.h ('K') | « chrome/browser/history/history_backend.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698