Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4179)

Unified Diff: chrome/browser/history/android/android_history_provider_service.cc

Issue 365133003: Change AndroidHistoryProviderService to use CancelableTaskTracker (4/6) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.4
Patch Set: clang-format Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/android/android_history_provider_service.cc
diff --git a/chrome/browser/history/android/android_history_provider_service.cc b/chrome/browser/history/android/android_history_provider_service.cc
index 67e2c47c2a19d1ab69929283ac5a72940b35551e..e008b54679b2ac36f1715af5c49b2f18fbbcdc04 100644
--- a/chrome/browser/history/android/android_history_provider_service.cc
+++ b/chrome/browser/history/android/android_history_provider_service.cc
@@ -88,22 +88,27 @@ AndroidHistoryProviderService::DeleteHistoryAndBookmarks(
return request->handle();
}
-AndroidHistoryProviderService::Handle
+base::CancelableTaskTracker::TaskId
AndroidHistoryProviderService::InsertHistoryAndBookmark(
const history::HistoryAndBookmarkRow& values,
- CancelableRequestConsumerBase* consumer,
- const InsertCallback& callback) {
- InsertRequest* request = new InsertRequest(callback);
- AddRequest(request, consumer);
+ const InsertCallback& callback,
+ base::CancelableTaskTracker* tracker) {
HistoryService* hs =
HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
if (hs) {
- hs->Schedule(HistoryService::PRIORITY_NORMAL,
- &HistoryBackend::InsertHistoryAndBookmark, NULL, request, values);
+ DCHECK(hs->thread_) << "History service being called after cleanup";
+ DCHECK(hs->thread_checker_.CalledOnValidThread());
+ return tracker->PostTaskAndReplyWithResult(
+ hs->thread_->message_loop_proxy().get(),
+ FROM_HERE,
+ base::Bind(&HistoryBackend::InsertHistoryAndBookmark,
+ hs->history_backend_.get(),
+ values),
+ callback);
} else {
- request->ForwardResultAsync(request->handle(), false, 0);
+ callback.Run(0);
+ return base::CancelableTaskTracker::kBadTaskId;
}
- return request->handle();
}
AndroidHistoryProviderService::Handle
@@ -165,22 +170,26 @@ void AndroidHistoryProviderService::CloseStatement(
}
}
-AndroidHistoryProviderService::Handle
+base::CancelableTaskTracker::TaskId
AndroidHistoryProviderService::InsertSearchTerm(
const history::SearchRow& row,
- CancelableRequestConsumerBase* consumer,
- const InsertCallback& callback) {
- InsertRequest* request = new InsertRequest(callback);
- AddRequest(request, consumer);
+ const InsertCallback& callback,
+ base::CancelableTaskTracker* tracker) {
HistoryService* hs =
HistoryServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
if (hs) {
- hs->Schedule(HistoryService::PRIORITY_NORMAL,
- &HistoryBackend::InsertSearchTerm, NULL, request, row);
+ DCHECK(hs->thread_) << "History service being called after cleanup";
+ DCHECK(hs->thread_checker_.CalledOnValidThread());
+ return tracker->PostTaskAndReplyWithResult(
+ hs->thread_->message_loop_proxy().get(),
+ FROM_HERE,
+ base::Bind(
+ &HistoryBackend::InsertSearchTerm, hs->history_backend_.get(), row),
+ callback);
} else {
- request->ForwardResultAsync(request->handle(), false, 0);
+ callback.Run(0);
+ return base::CancelableTaskTracker::kBadTaskId;
}
- return request->handle();
}
AndroidHistoryProviderService::Handle

Powered by Google App Engine
This is Rietveld 408576698