Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 365133003: Change AndroidHistoryProviderService to use CancelableTaskTracker (4/6) (Closed)

Created:
6 years, 5 months ago by sdefresne
Modified:
6 years, 5 months ago
Reviewers:
Miguel Garcia, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.4
Project:
chromium
Visibility:
Public.

Description

Change AndroidHistoryProviderService to use CancelableTaskTracker (4/6) Port InsertHistoryAndBookmark and InsertSearchTerm to use base::CancelableTaskTracker instead of CancelableRequestConsumer. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283821

Patch Set 1 #

Patch Set 2 : clang-format #

Total comments: 2

Patch Set 3 : Document methods #

Patch Set 4 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -77 lines) Patch
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.h View 1 2 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service.cc View 1 2 chunks +27 lines, -18 lines 0 comments Download
M chrome/browser/history/android/android_history_provider_service_unittest.cc View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/history/android/sqlite_cursor_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend_android.cc View 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sdefresne
Could you please take a look? This is the fourth of a series of seven ...
6 years, 5 months ago (2014-07-03 17:18:57 UTC) #1
blundell
lgtm
6 years, 5 months ago (2014-07-04 09:55:50 UTC) #2
sdefresne
+miguelg for OWNERS of //chrome/browser/android
6 years, 5 months ago (2014-07-04 12:26:44 UTC) #3
Miguel Garcia
lgtm https://codereview.chromium.org/365133003/diff/20001/chrome/browser/history/history_backend.h File chrome/browser/history/history_backend.h (right): https://codereview.chromium.org/365133003/diff/20001/chrome/browser/history/history_backend.h#newcode288 chrome/browser/history/history_backend.h:288: AndroidURLID InsertHistoryAndBookmark(const HistoryAndBookmarkRow& row); please document both methods
6 years, 5 months ago (2014-07-07 09:54:49 UTC) #4
sdefresne
https://codereview.chromium.org/365133003/diff/20001/chrome/browser/history/history_backend.h File chrome/browser/history/history_backend.h (right): https://codereview.chromium.org/365133003/diff/20001/chrome/browser/history/history_backend.h#newcode288 chrome/browser/history/history_backend.h:288: AndroidURLID InsertHistoryAndBookmark(const HistoryAndBookmarkRow& row); On 2014/07/07 09:54:49, Miguel Garcia ...
6 years, 5 months ago (2014-07-16 11:51:08 UTC) #5
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 5 months ago (2014-07-17 14:25:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/365133003/60001
6 years, 5 months ago (2014-07-17 14:26:00 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 18:24:45 UTC) #8
Message was sent while issue was closed. 
Change committed as 283821

Powered by Google App Engine
This is Rietveld 408576698