chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm - Issue 365123003: Implement midi permissions on top of the new common permission classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Issue 365123003: Implement midi permissions on top of the new common permission classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/permission_context_base.cc ('K') | « chrome/browser/services/gcm/push_messaging_permission_context.h ('k') | chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

index 1a2293557af964185daad0552813cf7522fc1756..655a8d4f2f28a7431e67017d5e2860808732c92d 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

@@ -281,8 +281,6 @@ class ContentSettingBubbleWebContentsObserverBridge

case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:

case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:

case CONTENT_SETTINGS_NUM_TYPES:

- // TODO(miguelg): Remove this when bubble support is implemented

- case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:

NOTREACHED();

}

if ((self = [super initWithWindowNibPath:nibPath