chrome/browser/content_settings/permission_bubble_request_impl.h - Issue 365123003: Implement midi permissions on top of the new common permission classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.h

Issue 365123003: Implement midi permissions on top of the new common permission classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/content_settings/permission_bubble_request_impl.cc » ('j') | chrome/browser/content_settings/permission_context_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_bubble_request_impl.h

diff --git a/chrome/browser/services/gcm/permission_bubble_request_impl.h b/chrome/browser/content_settings/permission_bubble_request_impl.h

similarity index 87%

rename from chrome/browser/services/gcm/permission_bubble_request_impl.h

rename to chrome/browser/content_settings/permission_bubble_request_impl.h

index 57f7cf8ed0fa16eb956dd2d42be20aef1d409fa8..fe73c64cdf3548e24d9d023c663e287fd435a7bb 100644

--- a/chrome/browser/services/gcm/permission_bubble_request_impl.h

+++ b/chrome/browser/content_settings/permission_bubble_request_impl.h

@@ -2,8 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_SERVICES_GCM_PERMISSION_BUBBLE_REQUEST_IMPL_H_

-#define CHROME_BROWSER_SERVICES_GCM_PERMISSION_BUBBLE_REQUEST_IMPL_H_

+#ifndef CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_BUBBLE_REQUEST_IMPL_H_

+#define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_BUBBLE_REQUEST_IMPL_H_

#include "base/callback.h"

#include "chrome/browser/content_settings/permission_request_id.h"

@@ -12,9 +12,6 @@

class GURL;

-// TODO(miguelg): move this class out of GCM.

-namespace gcm {

class PermissionContextBase;

// Default implementation of PermissionBubbleRequest, it is assumed that the

@@ -66,5 +63,4 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

DISALLOW_COPY_AND_ASSIGN(PermissionBubbleRequestImpl);

};

-} // namespace gcm

-#endif // CHROME_BROWSER_SERVICES_GCM_PERMISSION_BUBBLE_REQUEST_IMPL_H_

+#endif // CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_BUBBLE_REQUEST_IMPL_H_