Invalidation set features recognized left of adjacent.

Source/core/css/RuleFeature.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 101 matching lines @@
 }
 
 void RuleFeature::trace(Visitor* visitor)
 {
     visitor->trace(rule);
 }
 
 // This method is somewhat conservative in what it accepts.
 RuleFeatureSet::InvalidationSetMode RuleFeatureSet::invalidationSetModeForSelector(const CSSSelector& selector)
 {
-    bool foundDescendantRelation = false;
+    bool foundCombinator = false;
     bool foundIdent = false;
     for (const CSSSelector* component = &selector; component; component = component->tagHistory()) {
 
         if (component->match() == CSSSelector::Class || component->match() == CSSSelector::Id
             || (component->match() == CSSSelector::Tag && component->tagQName().localName() != starAtom)
             || component->isAttributeSelector() || component->isCustomPseudoElement()) {
-            if (!foundDescendantRelation)
+            if (!foundCombinator)
                 foundIdent = true;
         } else if (component->pseudoType() == CSSSelector::PseudoHost || component->pseudoType() == CSSSelector::PseudoAny) {
             if (const CSSSelectorList* selectorList = component->selectorList()) {
                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector)) {
                     InvalidationSetMode hostMode = invalidationSetModeForSelector(*selector);
                     if (hostMode == UseSubtreeStyleChange)
-                        return foundDescendantRelation ? UseLocalStyleChange : UseSubtreeStyleChange;
-                    if (!foundDescendantRelation && hostMode == AddFeatures)
+                        return foundCombinator ? UseLocalStyleChange : UseSubtreeStyleChange;
+                    if (!foundCombinator && hostMode == AddFeatures)
                         foundIdent = true;
                 }
             }
         } else if (!isSkippableComponentForInvalidation(*component)) {
-            return foundDescendantRelation ? UseLocalStyleChange : UseSubtreeStyleChange;
+            return foundCombinator ? UseLocalStyleChange : UseSubtreeStyleChange;
         }
-        switch (component->relation()) {
-        case CSSSelector::Descendant:
-        case CSSSelector::Child:
-        case CSSSelector::ShadowPseudo:
-        case CSSSelector::ShadowDeep:
-            foundDescendantRelation = true;
-            // Fall through!
-        case CSSSelector::SubSelector:
-        case CSSSelector::DirectAdjacent:
-        case CSSSelector::IndirectAdjacent:
-            continue;
-        default:
-            // All combinators should be handled above.
-            ASSERT_NOT_REACHED();
-            return UseLocalStyleChange;
-        }
+        if (component->relation() != CSSSelector::SubSelector)
+            foundCombinator = true;
     }
     return foundIdent ? AddFeatures : UseLocalStyleChange;
 }
 
 void RuleFeatureSet::extractInvalidationSetFeature(const CSSSelector& selector, InvalidationSetFeatures& features)
 {
     if (selector.match() == CSSSelector::Tag)
         features.tagName = selector.tagQName().localName();
     else if (selector.match() == CSSSelector::Id)
         features.id = selector.value();
@@ skipping 57 matching lines @@
 
         switch (current->relation()) {
         case CSSSelector::SubSelector:
             break;
         case CSSSelector::ShadowPseudo:
         case CSSSelector::ShadowDeep:
             features.treeBoundaryCrossing = true;
             return current->tagHistory();
         case CSSSelector::DirectAdjacent:
         case CSSSelector::IndirectAdjacent:
+            // Style invalidation is currently supported for descendants only, not for sibling subtrees.
+            // Use wholeSubtree invalidation for adjacent combinators as SubtreeStyleChange will force
+            // sibling subtree recalc in ContainerNode::checkForChildrenAdjacentRuleChanges.
             features.wholeSubtree = true;
             return current->tagHistory();
         case CSSSelector::Descendant:
         case CSSSelector::Child:
             return current->tagHistory();
         }
     }
     return 0;
 }
 
@@ skipping 24 matching lines @@
                 for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
                     addFeaturesToInvalidationSets(*selector, features);
             }
         }
         switch (current->relation()) {
         case CSSSelector::SubSelector:
             break;
         case CSSSelector::ShadowPseudo:
         case CSSSelector::ShadowDeep:
             features.treeBoundaryCrossing = true;
+            // If we saw an adjacent combinator, wholeSubtree would have been set to true. A descendant
+            // type combinator cancels out the need for that.
             features.wholeSubtree = false;
             break;
         case CSSSelector::Descendant:
         case CSSSelector::Child:
+            // If we saw an adjacent combinator, wholeSubtree would have been set to true. A descendant
+            // type combinator cancels out the need for that.
             features.wholeSubtree = false;
             break;
         case CSSSelector::DirectAdjacent:
         case CSSSelector::IndirectAdjacent:
+            // Style invalidation is currently supported for descendants only, not for sibling subtrees.
+            // Use wholeSubtree invalidation for adjacent combinators as SubtreeStyleChange will force
+            // sibling subtree recalc in ContainerNode::checkForChildrenAdjacentRuleChanges.

[esprehn, 2014/08/16 07:58:34]

Not a fan of the copy pasta comments. Can you just put a comment above the
functions and explain what they do instead?

[rune, 2014/08/18 21:13:06]

Done.

             features.wholeSubtree = true;
             break;
         }
     }
 }
 
 void RuleFeatureSet::addContentAttr(const AtomicString& attributeName)
 {
     DescendantInvalidationSet& invalidationSet = ensureAttributeInvalidationSet(attributeName);
     invalidationSet.setWholeSubtreeInvalid();
@@ skipping 223 matching lines @@
     visitor->trace(uncommonAttributeRules);
     visitor->trace(m_classInvalidationSets);
     visitor->trace(m_attributeInvalidationSets);
     visitor->trace(m_idInvalidationSets);
     visitor->trace(m_pseudoInvalidationSets);
     visitor->trace(m_styleInvalidator);
 #endif
 }
 
 } // namespace blink