Experimental app list: Custom launcher pages have app APIs and style.

chrome/browser/ui/app_list/app_list_view_delegate.cc

Index: chrome/browser/ui/app_list/app_list_view_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_view_delegate.cc b/chrome/browser/ui/app_list/app_list_view_delegate.cc
index 7af49bd8ab2e09fe566580e2dec68b9d91ad378a..e21d7738b0d884b25a08e0ffb634f4a9a0b3a291 100644
--- a/chrome/browser/ui/app_list/app_list_view_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_view_delegate.cc
@@ -6,6 +6,7 @@
 
 #include <vector>
 
+#include "apps/custom_launcher_page_contents.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ -162,13 +163,9 @@ AppListViewDelegate::AppListViewDelegate(Profile* profile,
       LOG(ERROR) << "Invalid custom launcher page URL: "
                  << custom_launcher_page_url.possibly_invalid_spec();
     } else {
-      content::WebContents::CreateParams params(profile_);
-      custom_page_web_contents_.reset(content::WebContents::Create(params));
-      custom_page_web_contents_->GetController().LoadURL(
-          custom_launcher_page_url,
-          content::Referrer(),
-          content::PAGE_TRANSITION_AUTO_TOPLEVEL,
-          std::string());
+      custom_page_contents_.reset(new apps::CustomLauncherPageContents());
+      custom_page_contents_->Initialize(profile, custom_launcher_page_url);

[tapted, 2014/07/10 04:29:34]

Should this be in OnProfileChanged() to properly handle profile switching, and
deleting a profile from chrome://settings?

Alternatively, I think you could you just move this into
AppListViewDelegate::CreateCustomPageWebView, and reset it when that's called
via AppListMainView->ModelChanged() which will create a new ContentsView

[Matt Giuca, 2014/07/10 07:37:03]

Good catch! This is actually a pre-existing bug. So I have filed it and will
address it in a follow-up:
https://code.google.com/p/chromium/issues/detail?id=392763

+      custom_page_contents_->LoadContents();
     }
   }
 }
@@ -481,13 +478,14 @@ views::View* AppListViewDelegate::CreateStartPageWebView(
 
 views::View* AppListViewDelegate::CreateCustomPageWebView(
     const gfx::Size& size) {
-  if (!custom_page_web_contents_)
+  if (!custom_page_contents_)
     return NULL;
 
-  views::WebView* web_view = new views::WebView(
-      custom_page_web_contents_->GetBrowserContext());
+  content::WebContents* web_contents = custom_page_contents_->GetWebContents();
+  views::WebView* web_view =
+      new views::WebView(web_contents->GetBrowserContext());

[tapted, 2014/07/10 04:29:34]

is web_contents->GetBrowserContext() equivalent to this->profile_? You could use
that and 
  views::WebView* web_view = new views::WebView(profile_);
  web_view->SetWebContents(custom_page_contents_->web_contents());

[Matt Giuca, 2014/07/10 07:37:03]

Hmm, yeah they SHOULD be equivalent (but actually is not, due to the
aforementioned bug, Issue 392763).

I think the right thing to do is still to use GetBrowserContext() since you are
creating a WebView for a WebContents and the main source of truth about which
profile is the GetBrowserContext().

But it is good to add a DCHECK to ensure these are the same. I've done that in
Chris's code just above (which I copied this from). However, I can't add the
DCHECK to my code right now; added a TODO.

   web_view->SetPreferredSize(size);
-  web_view->SetWebContents(custom_page_web_contents_.get());
+  web_view->SetWebContents(web_contents);
   return web_view;
 }
 #endif