Experimental app list: Custom launcher pages have app APIs and style.

chrome/browser/ui/app_list/app_list_view_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_view_delegate.h"
 
 #include <vector>
 
+#include "apps/custom_launcher_page_contents.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/metrics/user_metrics.h"
 #include "base/stl_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/search/hotword_service.h"
 #include "chrome/browser/search/hotword_service_factory.h"
 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
 #include "chrome/browser/ui/app_list/app_list_service.h"
 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"
 #include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
 #include "chrome/browser/ui/app_list/search/search_controller.h"
 #include "chrome/browser/ui/app_list/start_page_service.h"
@@ skipping 129 matching lines @@
   // arbitrary extensions may be able to specify their own custom pages.
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (app_list::switches::IsExperimentalAppListEnabled() &&
       command_line->HasSwitch(switches::kCustomLauncherPage)) {
     GURL custom_launcher_page_url(
         command_line->GetSwitchValueASCII(switches::kCustomLauncherPage));
     if (!custom_launcher_page_url.SchemeIs(extensions::kExtensionScheme)) {
       LOG(ERROR) << "Invalid custom launcher page URL: "
                  << custom_launcher_page_url.possibly_invalid_spec();
     } else {
-      content::WebContents::CreateParams params(profile_);
-      custom_page_web_contents_.reset(content::WebContents::Create(params));
-      custom_page_web_contents_->GetController().LoadURL(
-          custom_launcher_page_url,
-          content::Referrer(),
-          content::PAGE_TRANSITION_AUTO_TOPLEVEL,
-          std::string());
+      custom_page_contents_.reset(new apps::CustomLauncherPageContents());
+      custom_page_contents_->Initialize(profile, custom_launcher_page_url);
+      // This observer will activate the extension when it is navigated to,
+      // which allows Dispatcher to give it the proper context and makes it
+      // behave like an extension.
+      extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(

[not at google - send to devlin, 2014/07/09 15:14:39]

seems like it would be better for CustomLauncherPageContents to do this itself.

[Matt Giuca, 2014/07/10 03:45:17]

Yeah I agree. I didn't do it for consistency with AppWindowContents (which does
this part on the outside) but I think it's best to encapsulate it so I will
change.

+          custom_page_contents_->GetWebContents());
+      custom_page_contents_->LoadContents();
     }
   }
 }
 
 AppListViewDelegate::~AppListViewDelegate() {
   app_list::StartPageService* service =
       app_list::StartPageService::Get(profile_);
   if (service)
     service->RemoveObserver(this);
   g_browser_process->
@@ skipping 292 matching lines @@
 
   views::WebView* web_view = new views::WebView(
       web_contents->GetBrowserContext());
   web_view->SetPreferredSize(size);
   web_view->SetWebContents(web_contents);
   return web_view;
 }
 
 views::View* AppListViewDelegate::CreateCustomPageWebView(
     const gfx::Size& size) {
-  if (!custom_page_web_contents_)
+  if (!custom_page_contents_)
     return NULL;
 
-  views::WebView* web_view = new views::WebView(
-      custom_page_web_contents_->GetBrowserContext());
+  content::WebContents* web_contents = custom_page_contents_->GetWebContents();
+  views::WebView* web_view =
+      new views::WebView(web_contents->GetBrowserContext());
   web_view->SetPreferredSize(size);
-  web_view->SetWebContents(custom_page_web_contents_.get());
+  web_view->SetWebContents(web_contents);
   return web_view;
 }
 #endif
 
 bool AppListViewDelegate::IsSpeechRecognitionEnabled() {
   app_list::StartPageService* service =
       app_list::StartPageService::Get(profile_);
   return service && service->GetSpeechRecognitionContents();
 }
 
@@ skipping 32 matching lines @@
 
 void AppListViewDelegate::AddObserver(
     app_list::AppListViewDelegateObserver* observer) {
   observers_.AddObserver(observer);
 }
 
 void AppListViewDelegate::RemoveObserver(
     app_list::AppListViewDelegateObserver* observer) {
   observers_.RemoveObserver(observer);
 }