Experimental app list: Custom launcher pages have app APIs and style.

apps/custom_launcher_page_contents.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef APPS_CUSTOM_LAUNCHER_PAGE_CONTENTS_H_
+#define APPS_CUSTOM_LAUNCHER_PAGE_CONTENTS_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "extensions/browser/extension_function_dispatcher.h"
+
+class GURL;

[tapted, 2014/07/10 04:29:34]

this is a data member, so should probably have an #include. Alternatively, I
think you can remove the data member as well as LoadContents(), and just do the
LoadURL step at the end of Initialize (unless you have other plans for these)

[Matt Giuca, 2014/07/10 07:37:03]

Done (latter).

+
+namespace content {
+class BrowserContext;
+}
+
+namespace apps {
+
+// Manages the web contents for extension-hosted launcher pages. The
+// implementation for this class should create and maintain the WebContents for
+// the page, and handle any message passing between the web contents and the
+// extension system.
+class CustomLauncherPageContents
+    : public content::WebContentsObserver,
+      public extensions::ExtensionFunctionDispatcher::Delegate {
+ public:
+  CustomLauncherPageContents();
+  virtual ~CustomLauncherPageContents();
+
+  // Called to initialize the WebContents, before the app window is created.
+  void Initialize(content::BrowserContext* context, const GURL& url);
+
+  // Called to load the contents, after the app window is created.
+  void LoadContents();
+
+  content::WebContents* GetWebContents() const;

[tapted, 2014/07/10 04:29:34]

nit: use a hacker_style inline accessor? Or call GetAssociatedWebContents()
instead? (I'd probably go hacker_style, and prefer web_contents() over
web_contents_.get() in the .cc)

[Matt Giuca, 2014/07/10 07:37:03]

Done.

+
+ private:
+  // content::WebContentsObserver

[tapted, 2014/07/10 04:29:34]

nit: I usualy see a colon after these

[Matt Giuca, 2014/07/10 07:37:03]

Done.

+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+
+  // extensions::ExtensionFunctionDispatcher::Delegate
+  virtual extensions::WindowController* GetExtensionWindowController()
+      const OVERRIDE;
+  virtual content::WebContents* GetAssociatedWebContents() const OVERRIDE;
+
+  void OnRequest(const ExtensionHostMsg_Request_Params& params);
+
+  GURL url_;
+  scoped_ptr<content::WebContents> web_contents_;
+  scoped_ptr<extensions::ExtensionFunctionDispatcher>
+      extension_function_dispatcher_;
+
+  DISALLOW_COPY_AND_ASSIGN(CustomLauncherPageContents);
+};
+
+}  // namespace apps
+
+#endif  // APPS_CUSTOM_LAUNCHER_PAGE_CONTENTS_H_