net/socket/ssl_client_socket.h - Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket.h

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed OnSocketFailure callback to run directly & fixed comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket.h

diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h

index 64e3dc74e4e4ce2c50dc95896c2a2876b696f6d3..1caabcf00e6286de9fd841a3f003316069f431d1 100644

--- a/net/socket/ssl_client_socket.h

+++ b/net/socket/ssl_client_socket.h

@@ -99,6 +99,9 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {

virtual void WatchSessionForCompletion(const base::Closure& callback) = 0;

// Sets the callback to be used if the socket's connection should fail.

+ //

+ // Note: This callback may still be executed even if this socket has

+ // been disconnected or deleted.

wtc 2014/07/14 22:39:18 Delete this comment.

mshelley 2014/07/17 16:28:03 Done.

virtual void SetSocketFailureCallback(const base::Closure& callback) = 0;

// Marks this socket as the leading connection.

« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.cc » ('j') | net/socket/ssl_client_socket_openssl.cc » ('J')