Makes waiting SSLConnectJobs use the message loops to resume their connection.

net/socket/ssl_client_socket_openssl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // OpenSSL binding for SSLClientSocket. The class layout and general principle
 // of operation is derived from SSLClientSocketNSS.
 
 #include "net/socket/ssl_client_socket_openssl.h"
 
 #include <openssl/err.h>
@@ skipping 376 matching lines @@
     const base::Closure& callback) {
   error_callback_ = callback;
 }
 
 void SSLClientSocketOpenSSL::SetIsLeader() {
   is_leader_ = true;
 }
 
 void SSLClientSocketOpenSSL::OnSocketFailure() {
   if (is_leader_) {
-    error_callback_.Run();
+    // error_callback_ should be run regardless of the validity of this
+    // SSLClientSocketOpenSSL at the callback's runtime.

[Ryan Sleevi, 2014/07/10 02:34:25]

Note: The request for documentation was meant for the header, so that the
caller/supplier of error_callback_ knows exactly when/how it can be invoked.

[mshelley, 2014/07/10 16:35:32]

Done.

+    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, error_callback_);
     error_callback_ = base::Closure();
     is_leader_ = false;
   }
 }
 
 void SSLClientSocketOpenSSL::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   cert_request_info->host_and_port = host_and_port_;
   cert_request_info->cert_authorities = cert_authorities_;
   cert_request_info->cert_key_types = cert_key_types_;
@@ skipping 982 matching lines @@
   std::vector<uint8> encrypted_private_key_info;
   std::vector<uint8> subject_public_key_info;
   encrypted_private_key_info.assign(
       channel_id_private_key_.data(),
       channel_id_private_key_.data() + channel_id_private_key_.size());
   subject_public_key_info.assign(
       channel_id_cert_.data(),
       channel_id_cert_.data() + channel_id_cert_.size());
   scoped_ptr<crypto::ECPrivateKey> ec_private_key(
       crypto::ECPrivateKey::CreateFromEncryptedPrivateKeyInfo(
-          ServerBoundCertService::kEPKIPassword,
+          SperverBoundCertService::kEPKIPassword,
           encrypted_private_key_info,
           subject_public_key_info));
   if (!ec_private_key)
     return;
   set_channel_id_sent(true);
   *pkey = EVP_PKEY_dup(ec_private_key->key());
 }
 
 int SSLClientSocketOpenSSL::CertVerifyCallback(X509_STORE_CTX* store_ctx) {
   if (!completed_handshake_) {
@@ skipping 64 matching lines @@
   DVLOG(2) << "next protocol: '" << npn_proto_ << "' status: " << npn_status_;
   return SSL_TLSEXT_ERR_OK;
 }
 
 scoped_refptr<X509Certificate>
 SSLClientSocketOpenSSL::GetUnverifiedServerCertificateChain() const {
   return server_cert_;
 }
 
 }  // namespace net