Makes waiting SSLConnectJobs use the message loops to resume their connection.

net/socket/ssl_client_socket_openssl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // OpenSSL binding for SSLClientSocket. The class layout and general principle
 // of operation is derived from SSLClientSocketNSS.
 
 #include "net/socket/ssl_client_socket_openssl.h"
 
 #include <openssl/err.h>
 #include <openssl/opensslv.h>
 #include <openssl/ssl.h>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "base/synchronization/lock.h"
+#include "base/thread_task_runner_handle.h"
 #include "crypto/ec_private_key.h"
 #include "crypto/openssl_util.h"
 #include "net/base/net_errors.h"
 #include "net/cert/cert_verifier.h"
 #include "net/cert/single_request_cert_verifier.h"
 #include "net/cert/x509_certificate_net_log_param.h"
 #include "net/socket/openssl_ssl_util.h"
 #include "net/socket/ssl_client_socket_pool.h"
 #include "net/socket/ssl_error_params.h"
 #include "net/socket/ssl_session_cache_openssl.h"
@@ skipping 359 matching lines @@
     const base::Closure& callback) {
   error_callback_ = callback;
 }
 
 void SSLClientSocketOpenSSL::SetIsLeader() {
   is_leader_ = true;
 }
 
 void SSLClientSocketOpenSSL::OnSocketFailure() {
   if (is_leader_) {
-    error_callback_.Run();
+    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, error_callback_);

[wtc, 2014/07/11 18:55:51]

IMPORTANT: Based on my understanding of the code, I suggest running this error
callback directly. This will allow us to remove the comment for
SetSocketFailureCallback, which would introduce a behavior uncommon in the
various Socket interfaces of our network stack:

 // NOTE: This callback may still be executed even if this socket has
 // been disconnected or deleted.

The error callback (SSLConnectJobMessenger::OnJobFailed) already posts a task.
So posting a task here would be redundant.

[mshelley, 2014/07/14 20:30:06]

Done.

     error_callback_ = base::Closure();
     is_leader_ = false;
   }
 }
 
 void SSLClientSocketOpenSSL::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   cert_request_info->host_and_port = host_and_port_;
   cert_request_info->cert_authorities = cert_authorities_;
   cert_request_info->cert_key_types = cert_key_types_;
@@ skipping 1068 matching lines @@
   DVLOG(2) << "next protocol: '" << npn_proto_ << "' status: " << npn_status_;
   return SSL_TLSEXT_ERR_OK;
 }
 
 scoped_refptr<X509Certificate>
 SSLClientSocketOpenSSL::GetUnverifiedServerCertificateChain() const {
   return server_cert_;
 }
 
 }  // namespace net