Issue 364923006: add GetOwnPropertyDescriptor to api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 364923006: add GetOwnPropertyDescriptor to api (Closed)

Created:
6 years, 5 months ago by dcarney

Modified:
6 years, 5 months ago

Reviewers:
aandrey, Toon Verwaest

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

add GetOwnPropertyDescriptor to api R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22190

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+5 lines, -0 lines	2 comments	Download
M	src/api.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm https://codereview.chromium.org/364923006/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/364923006/diff/1/include/v8.h#newcode2119 include/v8.h:2119: * Returns Object.GetOwnPropertyDescriptor as per ES5 section 15.2.3.3. ...

6 years, 5 months ago (2014-07-03 09:19:52 UTC) #2

dcarney

Committed patchset #1 manually as r22190 (presubmit successful).

6 years, 5 months ago (2014-07-03 10:05:14 UTC) #4

aandrey

6 years, 5 months ago (2014-07-13 12:54:54 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/364923006/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/364923006/diff/1/include/v8.h#newcode2121
include/v8.h:2121: Local<Value> GetOwnPropertyDescriptor(Local<String> key);
why not support Symbols as well?

Expand Messages | Collapse Messages