metrics: Add random delays to perf collection

chrome/browser/metrics/perf_provider_chromeos.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_PERF_PROVIDER_CHROMEOS_H_
 #define CHROME_BROWSER_METRICS_PERF_PROVIDER_CHROMEOS_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 67 matching lines @@
   void ScheduleCollection();
 
   // Collects perf data for a given |trigger_event|. Calls perf via the ChromeOS
   // debug daemon's dbus interface.
   void CollectIfNecessary(scoped_ptr<SampledProfile> sampled_profile);
 
   // Collects perf data on a repeating basis by calling CollectIfNecessary() and
   // reschedules it to be collected again.
   void DoPeriodicCollection();
 
+  // Collects perf data after a resume. |sleep_duration_ms| is the duration the

[Ilya Sherman, 2014/07/03 00:12:48]

nit: Perhaps name the variable "suspend_duration", then?

[Simon Que, 2014/07/07 19:45:26]

Done.

+  // system was suspended before resuming. |time_after_resume_ms| is how long
+  // ago the system resumed.
+  void DoResumeCollection(uint64 sleep_duration_ms,

[Ilya Sherman, 2014/07/03 00:12:48]

nit: Perhaps something more like "CollectPerfDataAfterResume" (and a similar
change below)?

[Simon Que, 2014/07/07 19:45:26]

Done.

+                          uint64 time_after_resume_ms);

[Ilya Sherman, 2014/07/03 00:12:48]

Please pass these as TimeDeltas.

[Simon Que, 2014/07/07 19:45:26]

Done.

+
+  // Collects perf data after a session restore. |time_after_restore_ms| is how
+  // long ago the session restore started.
+  void DoRestoreSessionCollection(uint64 time_after_restore_ms);
+
   // Parses a perf data protobuf from the |data| passed in only if the
   // |incognito_observer| indicates that no incognito window had been opened
   // during the profile collection period.
   // |trigger_event| is the cause of the perf data collection.
   void ParseProtoIfValid(
       scoped_ptr<WindowedIncognitoObserver> incognito_observer,
       scoped_ptr<SampledProfile> sampled_profile,
       const std::vector<uint8>& data);
 
   // Vector of SampledProfile protobufs containing perf profiles.
   std::vector<SampledProfile> cached_perf_data_;
 
-  // For scheduling collection of perf data.
-  base::OneShotTimer<PerfProvider> timer_;
+  // Timers for scheduling collection of perf data.
+
+  // Timer for interval-based collection.
+  base::OneShotTimer<PerfProvider> interval_timer_;
+  // Timer for collection on resume from suspend.
+  base::OneShotTimer<PerfProvider> resume_timer_;
+  // Timer for collection on restore session.
+  base::OneShotTimer<PerfProvider> restore_session_timer_;
 
   // For detecting when changes to the login state.
   LoginObserver login_observer_;
 
   // Record of the last login time.
   base::TimeTicks login_time_;
 
   // Record of the start of the upcoming profiling interval.
   base::TimeTicks next_profiling_interval_start_;
 
   // Used to register objects of this class as observers to be notified of
   // session restore events.
   content::NotificationRegistrar session_restore_registrar_;
 
   // Tracks the last time a session restore was collected.
   base::TimeTicks last_session_restore_collection_time_;
 
   // To pass around the "this" pointer across threads safely.
   base::WeakPtrFactory<PerfProvider> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PerfProvider);
 };
 
 }  // namespace metrics
 
 #endif  // CHROME_BROWSER_METRICS_PERF_PROVIDER_CHROMEOS_H_