Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 364853010: Move the iOS user agent functions to ios/web/public. (Closed)

Created:
6 years, 5 months ago by rohitrao (ping after 24h)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the iOS user agent functions to ios/web/public. The old implementations lived in //content, but they had no content dependencies, so they are safe to move to //web. BUG=390969 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281824

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -173 lines) Patch
D content/common/user_agent_ios.mm View 1 chunk +0 lines, -130 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ios/ios.gyp View 1 chunk +2 lines, -1 line 0 comments Download
D ios/ios_web.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
A + ios/provider/ios_provider_web.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + ios/web/ios_web.gyp View 1 chunk +10 lines, -7 lines 0 comments Download
A ios/web/public/user_agent.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A + ios/web/public/user_agent.mm View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rohitrao (ping after 24h)
6 years, 5 months ago (2014-07-07 17:26:10 UTC) #1
stuartmorgan
https://codereview.chromium.org/364853010/diff/1/ios/provider/ios_provider_web.gyp File ios/provider/ios_provider_web.gyp (right): https://codereview.chromium.org/364853010/diff/1/ios/provider/ios_provider_web.gyp#newcode17 ios/provider/ios_provider_web.gyp:17: 'public/provider/web/web_state_user_data.h', These need ../ also (it didn't complain only ...
6 years, 5 months ago (2014-07-07 18:43:57 UTC) #2
stuartmorgan
Oops, meant that to be an LGTM with nits.
6 years, 5 months ago (2014-07-07 18:44:12 UTC) #3
rohitrao (ping after 24h)
https://codereview.chromium.org/364853010/diff/1/ios/provider/ios_provider_web.gyp File ios/provider/ios_provider_web.gyp (right): https://codereview.chromium.org/364853010/diff/1/ios/provider/ios_provider_web.gyp#newcode17 ios/provider/ios_provider_web.gyp:17: 'public/provider/web/web_state_user_data.h', On 2014/07/07 18:43:57, stuartmorgan wrote: > These need ...
6 years, 5 months ago (2014-07-07 18:57:05 UTC) #4
rohitrao (ping after 24h)
+jam for OWNERS for the file deletion in content/.
6 years, 5 months ago (2014-07-07 18:57:42 UTC) #5
rohitrao (ping after 24h)
+Avi are you comfortable reviewing the file deletion in content/?
6 years, 5 months ago (2014-07-08 13:43:56 UTC) #6
Avi (use Gerrit)
lgtm I'm happy to rubber-stamp.
6 years, 5 months ago (2014-07-08 14:16:16 UTC) #7
rohitrao (ping after 24h)
The CQ bit was checked by rohitrao@chromium.org
6 years, 5 months ago (2014-07-08 14:24:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/364853010/40001
6 years, 5 months ago (2014-07-08 14:26:13 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-08 21:01:06 UTC) #10
Message was sent while issue was closed. 
Change committed as 281824

Powered by Google App Engine
This is Rietveld 408576698