Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: src/harmony-array.js

Issue 364853009: Implement ES6 Array.of() (Closed) Base URL: https://github.com/v8/v8@master
Patch Set: Fix indentation in harmony-array.js. Add comments to AddElement. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 'use strict'; 5 'use strict';
6 6
7 // This file relies on the fact that the following declaration has been made 7 // This file relies on the fact that the following declaration has been made
8 // in runtime.js: 8 // in runtime.js:
9 // var $Array = global.Array; 9 // var $Array = global.Array;
10 10
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 if ((end - i) > 0 && ObjectIsFrozen(array)) { 116 if ((end - i) > 0 && ObjectIsFrozen(array)) {
117 throw MakeTypeError("array_functions_on_frozen", 117 throw MakeTypeError("array_functions_on_frozen",
118 ["Array.prototype.fill"]); 118 ["Array.prototype.fill"]);
119 } 119 }
120 120
121 for (; i < end; i++) 121 for (; i < end; i++)
122 array[i] = value; 122 array[i] = value;
123 return array; 123 return array;
124 } 124 }
125 125
126 // ES6, draft 05-22-14, section 22.1.2.3
127 function ArrayOf() {
128 var length = %_ArgumentsLength();
129 var constructor = this;
130 // TODO: Implement IsConstructor (ES6 section 7.2.5)
131 var array = IS_SPEC_FUNCTION(constructor) ? new constructor(length) : [];
132 for (var i = 0; i < length; i++) {
133 %AddElement(array, i, %_Arguments(i), NONE);
134 }
135 array.length = length;
136 return array;
137 }
138
126 // ------------------------------------------------------------------- 139 // -------------------------------------------------------------------
127 140
128 function HarmonyArrayExtendArrayPrototype() { 141 function HarmonyArrayExtendArrayPrototype() {
129 %CheckIsBootstrapping(); 142 %CheckIsBootstrapping();
130 143
144 // Set up non-enumerable functions on the Array object.
145 InstallFunctions($Array, DONT_ENUM, $Array(
146 "of", ArrayOf
147 ));
148
131 // Set up the non-enumerable functions on the Array prototype object. 149 // Set up the non-enumerable functions on the Array prototype object.
132 InstallFunctions($Array.prototype, DONT_ENUM, $Array( 150 InstallFunctions($Array.prototype, DONT_ENUM, $Array(
133 "find", ArrayFind, 151 "find", ArrayFind,
134 "findIndex", ArrayFindIndex, 152 "findIndex", ArrayFindIndex,
135 "fill", ArrayFill 153 "fill", ArrayFill
136 )); 154 ));
137 } 155 }
138 156
139 HarmonyArrayExtendArrayPrototype(); 157 HarmonyArrayExtendArrayPrototype();
OLDNEW
« no previous file with comments | « no previous file | src/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698