Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 364853002: DevTools: Fix the way source map treats single field segment in the very end of mappings. (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix the way source map treats single field segment in the very end of mappings. BUG=224592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M LayoutTests/http/tests/inspector/compiler-script-mapping.html View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/compiler-script-mapping-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/SourceMap.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vsevik
PTAL
6 years, 5 months ago (2014-07-02 14:16:55 UTC) #1
apavlov
lgtm
6 years, 5 months ago (2014-07-02 14:25:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/364853002/1
6 years, 5 months ago (2014-07-02 14:25:44 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-02 15:40:18 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 16:48:11 UTC) #5
Message was sent while issue was closed.
Change committed as 177400

Powered by Google App Engine
This is Rietveld 408576698