Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 364793005: Implementation of GetFavicon for current tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/tab_android.h » ('j') | chrome/browser/android/tab_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
index c3835b6baa0af5c92054476c0b252fb1fc0dcbd2..fb1ff2baf3cd48b88ee88e9b4e366fbde2f40ae6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java
@@ -883,7 +883,9 @@ public class Tab implements NavigationClient {
* TODO(bauerb): Upstream implementation.
*/
public Bitmap getFavicon() {
- return null;
+ if (mNativeTabAndroid == 0)
+ return null;
+ return nativeGetCurrentTabFavicon(mNativeTabAndroid);
}
/**
@@ -1151,4 +1153,5 @@ public class Tab implements NavigationClient {
private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTabAndroid, String url,
String title);
private native boolean nativePrint(long nativeTabAndroid);
+ private native Bitmap nativeGetCurrentTabFavicon(long nativeTabAndroid);
}
« no previous file with comments | « no previous file | chrome/browser/android/tab_android.h » ('j') | chrome/browser/android/tab_android.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698