Implementation of GetFavicon for current tab.

chrome/android/java/src/org/chromium/chrome/browser/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Activity;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Color;
@@ skipping 121 matching lines @@
      */
     private int mParentId = INVALID_TAB_ID;
 
     /**
      * Whether the tab should be grouped with its parent tab.
      */
     private boolean mGroupedWithParent = true;
 
     private boolean mIsClosing = false;
 
+    private Bitmap mFavicon = null;
+
+    private String mFaviconUrl = null;
+
     /**
      * A default {@link ChromeContextMenuItemDelegate} that supports some of the context menu
      * functionality.
      */
     protected class TabChromeContextMenuItemDelegate
             extends EmptyChromeContextMenuItemDelegate {
         private final Clipboard mClipboard;
 
         /**
          * Builds a {@link TabChromeContextMenuItemDelegate} instance.
@@ skipping 726 matching lines @@
     @CalledByNative
     public String getTitle() {
         if (mNativePage != null) return mNativePage.getTitle();
         if (mContentViewCore != null) return mContentViewCore.getTitle();
         return "";
     }
 
     /**
      * @return The bitmap of the favicon scaled to 16x16dp. null if no favicon
      *         is specified or it requires the default favicon.
-     *         TODO(bauerb): Upstream implementation.
      */
     public Bitmap getFavicon() {
-        return null;
+        return mFavicon;
     }
 
     /**
      * Loads the tab if it's not loaded (e.g. because it was killed in background).
      * @return true iff tab load was triggered
      */
     @CalledByNative
     public boolean loadIfNeeded() {
         return false;
     }
@@ skipping 105 matching lines @@
      */
     protected TabChromeWebContentsDelegateAndroid getChromeWebContentsDelegateAndroid() {
         return mWebContentsDelegate;
     }
 
     /**
      * Called when the favicon of the content this tab represents changes.
      */
     @CalledByNative
     protected void onFaviconUpdated() {
-        for (TabObserver observer : mObservers) observer.onFaviconUpdated(this);
+        if (mContentViewCore != null) {
+            if ((mFaviconUrl == null) || (!mFaviconUrl.equals(mContentViewCore.getUrl()))) {

[David Trainor- moved to gerrit, 2014/07/21 18:18:17]

Could this change on a page refresh (even if the URL stays the same)?  Also if
nobody cares about the favicon we shouldn't bother building it.  Maybe we should
do something like:

onFaviconUpdated:
mFavicon = null;
mFaviconUrl = null;

getFavicon:
if (mFavicon == null || !cvcurl.equals(faviconurl)) buildFavicon;
return mFavicon;

[Jitu( very slow this week), 2014/07/24 14:08:21]

Changes done as per suggestion

+                if (mNativeTabAndroid == 0)
+                    return;
+                mFavicon = nativeGetFavicon(mNativeTabAndroid);
+                mFaviconUrl = mContentViewCore.getUrl();
+                for (TabObserver observer : mObservers) observer.onFaviconUpdated(this);
+            }
+        }
     }
 
     /**
      * Called when the navigation entry containing the historyitem changed,
      * for example because of a scroll offset or form field change.
      */
     @CalledByNative
     protected void onNavEntryChanged() {
     }
 
@@ skipping 121 matching lines @@
     private native void nativeDestroyWebContents(long nativeTabAndroid, boolean deleteNative);
     private native WebContents nativeGetWebContents(long nativeTabAndroid);
     private native Profile nativeGetProfileAndroid(long nativeTabAndroid);
     private native int nativeLoadUrl(long nativeTabAndroid, String url, String extraHeaders,
             byte[] postData, int transition, String referrerUrl, int referrerPolicy,
             boolean isRendererInitiated);
     private native int nativeGetSecurityLevel(long nativeTabAndroid);
     private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTabAndroid, String url,
             String title);
     private native boolean nativePrint(long nativeTabAndroid);
+    private native Bitmap nativeGetFavicon(long nativeTabAndroid);
 }