Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 364783003: Revert of Fix ExtensionPopup close issue. (Closed)

Created:
6 years, 5 months ago by Xuefei Ren
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Fix ExtensionPopup close issue. (https://codereview.chromium.org/321093002/) Reason for revert: Have to revert this. There is some cases such as when in extension open a new tab with window.open or a link, this will crash the browser.See bug 390128. Original issue's description: > Fix chrome.extension.getViews returns multiple popup windows. > > When we invoke +[ExtensionPopupController showURL:...], > we close the old Popup using [gPopup close],but we don't > release it here. So host_ is only released > when -[ExtensionPopupController windowWillClose] is invoked. > At this time, the new popup might be ready. And when we use > chrome.extension.getViews or some other apis we might get > the dying window. > So move shutdown of host_ from -[ExtensionPopupController windowWillClose] > into -[ExtensionPopupController close]. > > BUG=376511 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276355 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm View 3 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Xuefei Ren
Created Revert of Fix ExtensionPopup close issue.
6 years, 5 months ago (2014-07-02 06:07:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/364783003/1
6 years, 5 months ago (2014-07-02 06:08:51 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 06:08:52 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-02 06:08:52 UTC) #4
Xuefei Ren
Hi there, I am reverting this patch,but the bot said I need a LGTM from ...
6 years, 5 months ago (2014-07-02 06:40:24 UTC) #5
Mark Mentovai
LGTM
6 years, 5 months ago (2014-07-02 12:25:46 UTC) #6
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 5 months ago (2014-07-02 17:10:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/364783003/1
6 years, 5 months ago (2014-07-02 17:11:32 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 19:44:31 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 20:00:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/34583)
6 years, 5 months ago (2014-07-02 20:00:40 UTC) #11
Mike Wittman
The CQ bit was checked by wittman@chromium.org
6 years, 5 months ago (2014-07-02 20:53:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/364783003/1
6 years, 5 months ago (2014-07-02 20:54:15 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 21:03:35 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 21:17:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/34639)
6 years, 5 months ago (2014-07-02 21:17:09 UTC) #16
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 5 months ago (2014-07-03 01:51:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/364783003/1
6 years, 5 months ago (2014-07-03 01:52:48 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 03:26:04 UTC) #19
Message was sent while issue was closed.
Change committed as 281153

Powered by Google App Engine
This is Rietveld 408576698