DescriptionRevert of Fix ExtensionPopup close issue. (https://codereview.chromium.org/321093002/)
Reason for revert:
Have to revert this. There is some cases such as when in extension open a new tab with window.open or a link, this will crash the browser.See bug 390128.
Original issue's description:
> Fix chrome.extension.getViews returns multiple popup windows.
>
> When we invoke +[ExtensionPopupController showURL:...],
> we close the old Popup using [gPopup close],but we don't
> release it here. So host_ is only released
> when -[ExtensionPopupController windowWillClose] is invoked.
> At this time, the new popup might be ready. And when we use
> chrome.extension.getViews or some other apis we might get
> the dying window.
> So move shutdown of host_ from -[ExtensionPopupController windowWillClose]
> into -[ExtensionPopupController close].
>
> BUG=376511
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276355
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281153
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 19 (0 generated)
|