Foreign session pages now load into current tab.

chrome/browser/sessions/session_restore.h

Index: chrome/browser/sessions/session_restore.h
diff --git a/chrome/browser/sessions/session_restore.h b/chrome/browser/sessions/session_restore.h
index 4405c4b44d54fe1387c5439de5bfc04c8f4bfd3b..618e5c2478efa5957562a91557492d14930b47c7 100644
--- a/chrome/browser/sessions/session_restore.h
+++ b/chrome/browser/sessions/session_restore.h
@@ -65,7 +65,8 @@ class SessionRestore {
   // Specifically used in the restoration of a foreign session.  This method
   // restores the given session tab to the browser of |source_web_contents| if
   // the disposition is not NEW_WINDOW. Returns the WebContents corresponding
-  // to the restored tab.
+  // to the restored tab. The Android implementation of this method takes

[sky, 2013/11/06 21:19:42]

I don't like having a different ownership model for android. That makes it very
easy to do the wrong thing. Can't we have the caller deal with Android
specifics?

[apiccion, 2013/11/06 21:37:03]

The interaction with source_web_contents depends on the disposition parameter.
When opened in the current-tab: web_contents gets swapped out with a new one
(the old one needs to be deleted). But when opened in a new tab, we still need
to keep the old content.

If the caller were responsible for cleanup, we'd still need to update this
comment to indicate under which conditions.

We could create a separate android header. However, I think the simplest
solution lets android callers to know they should never reference
source_web_contents after calling this method.

[sky, 2013/11/07 01:12:24]

Actually, the non-android implementation does the same. How about a comment of:
'If |disposition| is CURRENT_TAB, |source_web_contents| may be destroyed.'

I say may as this invokes CloseWebContentsAt(), which may not destroy. One more
question though. You're directly deleting the WebContents, what about unload
handlers? Are they not supported on android?

[apiccion, 2013/11/11 05:25:49]

Done. Regarding unload handlers: Please see Yaron's comment. (I believe they're
unsupported)

+  // ownership of |source_web_contents|.
   static content::WebContents* RestoreForeignSessionTab(
       content::WebContents* source_web_contents,
       const SessionTab& tab,