Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/android/foreign_session_helper.h

Issue 36473002: Foreign session pages now load into current tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Newt Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/foreign_session_helper.h
diff --git a/chrome/browser/android/foreign_session_helper.h b/chrome/browser/android/foreign_session_helper.h
index 0a08159ac7d787bf926bd6cca3efd10fc2d4713b..26b91530c60fb2d6c49baf2e8a019ac2103cc9c4 100644
--- a/chrome/browser/android/foreign_session_helper.h
+++ b/chrome/browser/android/foreign_session_helper.h
@@ -28,10 +28,18 @@ class ForeignSessionHelper : public content::NotificationObserver {
jboolean IsTabSyncEnabled(JNIEnv* env, jobject obj);
void SetOnForeignSessionCallback(JNIEnv* env, jobject obj, jobject callback);
jboolean GetForeignSessions(JNIEnv* env, jobject obj, jobject result);
+ // TODO (apiccion): Remvoe this method once downstream CL Lands.
+ // See: https://code.google.com/p/chromium/issues/detail?id=257102
+ jboolean OpenForeignSessionTabOld(JNIEnv* env,
+ jobject obj,
+ jstring session_tag,
+ jint tab_id);
jboolean OpenForeignSessionTab(JNIEnv* env,
jobject obj,
+ jobject j_tab,
jstring session_tag,
- jint tab_id);
+ jint tab_id,
+ jint j_disposition);
newt (away) 2013/11/02 02:04:42 typically don't use j_ for primitive types (since
apiccion 2013/11/02 02:48:27 Done.
void SetForeignSessionCollapsed(JNIEnv* env,
jobject obj,
jstring session_tag,

Powered by Google App Engine
This is Rietveld 408576698