Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 364663002: Skip mjsunit/migrations test in debug mode to avoid timeout failures. (Closed)

Created:
6 years, 5 months ago by Igor Sheludko
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Skip mjsunit/migrations test in debug mode to avoid timeout failures. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
6 years, 5 months ago (2014-07-01 17:38:56 UTC) #1
Igor Sheludko
Committed patchset #1 manually as r22133 (presubmit successful).
6 years, 5 months ago (2014-07-01 17:39:35 UTC) #2
Yang
On 2014/07/01 17:39:35, Igor Sheludko wrote: > Committed patchset #1 manually as r22133 (presubmit successful). ...
6 years, 5 months ago (2014-07-02 07:16:03 UTC) #3
Igor Sheludko
6 years, 5 months ago (2014-07-02 09:58:54 UTC) #4
Message was sent while issue was closed.
On 2014/07/02 07:16:03, Yang wrote:
> On 2014/07/01 17:39:35, Igor Sheludko wrote:
> > Committed patchset #1 manually as r22133 (presubmit successful).
> 
> Maybe using TIMEOUT instead of SKIP is better, if you don't care about the
test
> taking a long time to run. That way, we would at least catch potential crashes
> or assertion failures.

Done in r22149, thanks!

Powered by Google App Engine
This is Rietveld 408576698