Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 364623002: Use subprocess.Popen to communicate with d8 (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
marja
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use subprocess.Popen to communicate with d8 Hopefully this will let us capture the error message related to the occasional build failures on mac BUG=370551 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280843

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/gypv8sh.py View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-01 15:00:56 UTC) #1
marja
lgtm
6 years, 5 months ago (2014-07-01 15:01:46 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-01 15:39:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/364623002/20001
6 years, 5 months ago (2014-07-01 15:39:35 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 18:01:32 UTC) #5
Message was sent while issue was closed.
Change committed as 280843

Powered by Google App Engine
This is Rietveld 408576698