Issue 364293003: Follow up to r177450, do not .As() an empty handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 364293003: Follow up to r177450, do not .As() an empty handle. (Closed)

Created:
6 years, 5 months ago by dominicc (has gone to gerrit)

Modified:
6 years, 5 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Follow up to r177450, do not .As() an empty handle. Windows dbg and Windows Oilpan apparently doesn't allow empty handles with .As(), which caused the webkit_unit_tests added in r177450 to fail. Move the empty-handle check before the cast (turns out ScriptPromise constructor casts anyway.) BUG=363967 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177499