Issue 364253003: rebaseline_server: if urlSchemaVersion is not specified, assume current

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 364253003: rebaseline_server: if urlSchemaVersion is not specified, assume current (Closed)

Created:
6 years, 5 months ago by epoger

Modified:
6 years, 5 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

rebaseline_server: if urlSchemaVersion is not specified, assume current Modification to https://codereview.chromium.org/368933002/ ('rebaseline_server: add urlSchemaVersion parameter') Means we don't need https://codereview.chromium.org/367173002/ ('add urlSchemaVersion to rebaseline_server link on buildbot console page') NOTREECHECKS=True NOTRY=True TBR=borenet Committed: https://skia.googlesource.com/skia/+/46e51e10ae9a061456a5135a9973755f0b64547c

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -21 lines)			Patch
M	gm/rebaseline_server/server.py	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	gm/rebaseline_server/static/constants.js	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	gm/rebaseline_server/static/loader.js	View	1 chunk	+5 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/364253003/1

6 years, 5 months ago (2014-07-03 17:50:24 UTC) #3

commit-bot: I haz the power

Change committed as 46e51e10ae9a061456a5135a9973755f0b64547c

6 years, 5 months ago (2014-07-03 17:50:36 UTC) #4

Message was sent while issue was closed.

LGTM