LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html - Issue 364233005: [New Multicolumn] Support for paged overflow. (By mstensho).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html

Issue 364233005: [New Multicolumn] Support for paged overflow. (By mstensho). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Run fast/pagination in virtual/regionbasedmulticol. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-auto-height-expected.html ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html

diff --git a/LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol.html b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html

similarity index 51%

copy from LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol.html

copy to LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html

index 5e0c761143db3ddd0b4dd8d7e2d1fe9135a57fa2..b9b17b4ab7b3871fe9cdbbb202e9a41befd8f36f 100644

--- a/LayoutTests/fast/multicol/newmulticol/regular-block-becomes-multicol.html

+++ b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/paged-becomes-multicol-fixed-height.html

@@ -1,20 +1,22 @@

<!DOCTYPE html>

<html>

<head>

- <title>Change regular block to multicol</title>

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

function test() {

var elm = document.getElementById('elm');

elm.offsetTop; // trigger layout

- elm.style.WebkitColumns = 4;

- elm.style.columns = 4;

+ elm.style.WebkitColumns = '4';

+ elm.style.columns = '4';

+ elm.style.overflow = 'visible';

}

</script>

</head>

<p>You should see the word 'PASS' below.</p>

- <div style="font-family:monospace; float:left;">

- <div id="elm" style="-webkit-column-gap:0; column-gap:0; orphans:1; widows:1;">

+ <div style="float:left;">

+ <div id="elm" style="overflow:-webkit-paged-x; -webkit-column-gap:0; column-gap:0; orphans:1; widows:1; height:7em; line-height:4em;">

P<br>

A<br>

S<br>