Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 364233002: Fix Mac bootstrap sandbox for 64-bit builds (Closed)

Created:
6 years, 5 months ago by Jiang Jiang
Modified:
6 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Mac bootstrap sandbox for 64-bit builds Mach look_up2 message structs should be aligned by 4 bytes like breakpad does, otherwise there will be a 192 bytes vs. 188 bytes difference for look_up2_request_10_7 when compiling in 64-bit. BUG=386330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sandbox/mac/os_compatibility.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jiang Jiang
6 years, 5 months ago (2014-07-03 14:59:53 UTC) #1
Robert Sesek
LGTM, nice catch. MIG also generates #pragma packs for Mach structs.
6 years, 5 months ago (2014-07-03 17:33:46 UTC) #2
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 5 months ago (2014-07-03 17:38:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/364233002/1
6 years, 5 months ago (2014-07-03 17:39:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-03 19:38:45 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 19:53:32 UTC) #6
Message was sent while issue was closed.
Change committed as 281313

Powered by Google App Engine
This is Rietveld 408576698