Remove updateFirstLetter and firstLineBlock from RenderSVGText.

Remove updateFirstLetter and firstLineBlock from RenderSVGText.

These two methods were originally added in
http://src.chromium.org/viewvc/blink?revision=61050&view=revision with an
associated crash test. The test (svg/text/text-style-invalid.svg) no longer
crashes with these two methods removed.

BUG=391288
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178057

[dsinclair, 2014-07-03 15:06:43]

PTAL.

pdr@, does this seem sane to you?

[pdr., 2014-07-07 18:19:53]

On 2014/07/03 15:06:43, dsinclair wrote:
> PTAL.
> 
> pdr@, does this seem sane to you?

Sorry for the long delay (holiday in the united states and I was avoiding real
email).

We no longer crash, so LGTM for this change.

This doesn't really fix crbug.com/391288 though, which is much more involved. Do
we support first letter at all in svg? If not, can you file a separate bug?

[dsinclair1, 2014-07-14 14:08:35]

On 2014/07/07 18:19:53, pdr wrote:
> On 2014/07/03 15:06:43, dsinclair wrote:
> > PTAL.
> > 
> > pdr@, does this seem sane to you?
> 
> Sorry for the long delay (holiday in the united states and I was avoiding real
> email).
> 
> We no longer crash, so LGTM for this change.
> 
> This doesn't really fix crbug.com/391288 though, which is much more involved.
Do
> we support first letter at all in svg? If not, can you file a separate bug?


It doesn't fix the bug itself, but it is working towards fixing the bug. I'm
trying to elliminate as many callers into updateFirstLetter as possible before
moving first letter before layout.

Does SVG support first letter? Reading through the WebKit bug
(https://bugs.webkit.org/show_bug.cgi?id=40481) it sounds like it doesn't and no
browser supports it. I'm happy to open a bug if you think it should be
supported.

http://www.w3.org/TR/SVG/styling.html#SVGStylingProperties
CSS2's dynamic pseudo-classes :hover, :active and :focus and pseudo-classes
:first-child, :visited, :link and :lang ([CSS2], section 5.11). The remaining
CSS2 pseudo-classes, including those having to do with generated content
([CSS2], chapter 12), are not part of the SVG language definition. An SVG
element gains focus when it is selected. See Text selection.

[dsinclair1, 2014-07-14 14:09:14]

The CQ bit was checked by dsinclair@google.com

[dsinclair1, 2014-07-14 14:09:17]

The CQ bit was unchecked by dsinclair@google.com

[dsinclair, 2014-07-14 14:09:27]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2014-07-14 14:09:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dsinclair@chromium.org/364223002/1

[commit-bot: I haz the power, 2014-07-14 14:12:40]

Change committed as 178057

[fs, 2014-07-14 14:20:40]

On 2014/07/14 14:08:35, dsinclair1 wrote:
> On 2014/07/07 18:19:53, pdr wrote:
> > On 2014/07/03 15:06:43, dsinclair wrote:
> > > PTAL.
> > > 
> > > pdr@, does this seem sane to you?
> > 
> > Sorry for the long delay (holiday in the united states and I was avoiding
real
> > email).
> > 
> > We no longer crash, so LGTM for this change.
> > 
> > This doesn't really fix crbug.com/391288 though, which is much more
involved.
> Do
> > we support first letter at all in svg? If not, can you file a separate bug?
> 
> 
> It doesn't fix the bug itself, but it is working towards fixing the bug. I'm
> trying to elliminate as many callers into updateFirstLetter as possible before
> moving first letter before layout.
> 
> Does SVG support first letter? Reading through the WebKit bug
> (https://bugs.webkit.org/show_bug.cgi?id=40481) it sounds like it doesn't and
no
> browser supports it. I'm happy to open a bug if you think it should be
> supported.
> 
> http://www.w3.org/TR/SVG/styling.html#SVGStylingProperties
> CSS2's dynamic pseudo-classes :hover, :active and :focus and pseudo-classes
> :first-child, :visited, :link and :lang ([CSS2], section 5.11). The remaining
> CSS2 pseudo-classes, including those having to do with generated content
> ([CSS2], chapter 12), are not part of the SVG language definition. An SVG
> element gains focus when it is selected. See Text selection.

ISTR that Gecko supports first-letter. Eventhough it's not specced (yet), the
general direction for text features in SVG2 is to move closer to CSS - after all
it ought to be reasonably easy to do something like first-letter using a
(potentially anonymous) <tspan>, so why not (IMHO).

[dsinclair, 2014-07-14 14:38:24]

On 2014/07/14 14:20:40, fs wrote:
> On 2014/07/14 14:08:35, dsinclair1 wrote:
> > On 2014/07/07 18:19:53, pdr wrote:
> > > On 2014/07/03 15:06:43, dsinclair wrote:
> > > > PTAL.
> > > > 
> > > > pdr@, does this seem sane to you?
> > > 
> > > Sorry for the long delay (holiday in the united states and I was avoiding
> real
> > > email).
> > > 
> > > We no longer crash, so LGTM for this change.
> > > 
> > > This doesn't really fix crbug.com/391288 though, which is much more
> involved.
> > Do
> > > we support first letter at all in svg? If not, can you file a separate
bug?
> > 
> > 
> > It doesn't fix the bug itself, but it is working towards fixing the bug. I'm
> > trying to elliminate as many callers into updateFirstLetter as possible
before
> > moving first letter before layout.
> > 
> > Does SVG support first letter? Reading through the WebKit bug
> > (https://bugs.webkit.org/show_bug.cgi?id=40481) it sounds like it doesn't
and
> no
> > browser supports it. I'm happy to open a bug if you think it should be
> > supported.
> > 
> > http://www.w3.org/TR/SVG/styling.html#SVGStylingProperties
> > CSS2's dynamic pseudo-classes :hover, :active and :focus and pseudo-classes
> > :first-child, :visited, :link and :lang ([CSS2], section 5.11). The
remaining
> > CSS2 pseudo-classes, including those having to do with generated content
> > ([CSS2], chapter 12), are not part of the SVG language definition. An SVG
> > element gains focus when it is selected. See Text selection.
> 
> ISTR that Gecko supports first-letter. Eventhough it's not specced (yet), the
> general direction for text features in SVG2 is to move closer to CSS - after
all
> it ought to be reasonably easy to do something like first-letter using a
> (potentially anonymous) <tspan>, so why not (IMHO).


Ok, filed crbug.com/393582.