Fixing ActivityLogger tests that were failing due to asynchronous handling of data: URLs.

Fixing ActivityLogger tests that were failing due to asynchronous handling of data: URLs.

BUG=390701
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177744

[pmarch, 2014-07-03 15:17:08]

Please have a look at this CL.

[haraken, 2014-07-03 15:50:24]

LGTM

[pmarch, 2014-07-08 12:26:33]

Hi Jochen

Can you please look at  Source/web/tests/ActivityLoggerTest.cpp

Thanks

[pfeldman, 2014-07-08 12:27:32]

lgtm

[jochen (gone - plz use gerrit), 2014-07-09 09:26:35]

https://codereview.chromium.org/364213004/diff/20001/Source/web/tests/Activit...
File Source/web/tests/ActivityLoggerTest.cpp (right):

https://codereview.chromium.org/364213004/diff/20001/Source/web/tests/Activit...
Source/web/tests/ActivityLoggerTest.cpp:82:
pumpPendingRequestsDoNotUse(m_webViewHelper.webViewImpl()->mainFrame());
why are you using a method that says "DoNotUse"? Can you add the person that
named the method like this as reviewer please?

[pmarch, 2014-07-09 09:29:55]

Hi Daniel

Can you please approve the use of pumpPendingRequestsDoNotUse

Thanks

[pmarch, 2014-07-09 09:31:23]

On 2014/07/09 09:26:35, jochen wrote:
>
https://codereview.chromium.org/364213004/diff/20001/Source/web/tests/Activit...
> File Source/web/tests/ActivityLoggerTest.cpp (right):
> 
>
https://codereview.chromium.org/364213004/diff/20001/Source/web/tests/Activit...
> Source/web/tests/ActivityLoggerTest.cpp:82:
> pumpPendingRequestsDoNotUse(m_webViewHelper.webViewImpl()->mainFrame());
> why are you using a method that says "DoNotUse"? Can you add the person that
> named the method like this as reviewer please?

I asked Daniel to approve the use of pumpPendingRequestsDoNotUse. He is OOO,
however,  he suggested to use this method in bug description
http://code.google.com/p/chromium/issues/detail?id=390701.

[jochen (gone - plz use gerrit), 2014-07-09 09:33:46]

ok, lgtm

[pmarch, 2014-07-09 09:34:47]

The CQ bit was checked by pmarch@chromium.org

[dcheng, 2014-07-09 09:35:42]

On 2014/07/09 at 09:33:46, jochen wrote:
> ok, lgtm

The context on why it's called suffixed with DoNotUse is because there was
previously a lot of cargo culting around randomly calling
serveAsynchronousMockedRequests() and runPendingTasks() in tests to make them
"work" and this is something I wanted to discourage (since 95% of the use cases
that people care about are already satisfied by the helpers in
FrameTestHelpers.h).

[commit-bot: I haz the power, 2014-07-09 09:35:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/364213004/20001

[dcheng, 2014-07-09 09:36:09]

On 2014/07/09 at 09:35:46, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/pmarch@chromium.org/364213004/20001

(also lgtm)

[commit-bot: I haz the power, 2014-07-09 10:51:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-07-09 15:08:43]

Change committed as 177744